Repository navigation
docs(loader): mark --dir as required and describe the watch throttle - #147
Merged
MartinFillon merged 1 commit intoNov 16, 2026
Merged
Conversation
The READMEs gave -d, --dir a default of .nanoforge/client and .nanoforge/server, but both loaders have no default and throw "No game dir specified". The server README also said changes are debounced; the watcher acts on the first change and ignores the next 100 ms. Closes NanoForge-dev#143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
MartinFillon
approved these changes
Nov 16, 2026
MartinFillon
left a comment
Contributor
There was a problem hiding this comment.
Hi, thanks you for your pr resolving this small issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #143.
-d, --dirrows inREADME.md,apps/client/README.mdandapps/server/README.mdsaid the default is.nanoforge/client/.nanoforge/server. Neither loader sets a default: both throwNo game dir specifiedwhen--diris missing (apps/client/src/server.ts,apps/server/src/server.ts). The tables now sayrequired.apps/server/README.mdsaid changes are "debounced to 100 ms".apps/server/src/watch.tsrestarts on the first change and ignores further changes for the next 100 ms (a throttle, with no trailing restart). The sentence now says that.How do you test this PR?
Docs only. The tables keep Prettier's column alignment. Compare the
--dirrows with theif (!dir) throwlines and the watch text withwatch.tslines 6-8.Written with Claude Code (Claude Opus 5.5) and checked by me.