Repository navigation
chore(deps): drop the unused @nanoforge-dev/actions dependency - #8
Merged
Merged
Conversation
No workflow of this repository uses it: the docs reach it through the docs-sync action of the source repositories (ADR 0010 planned to drop it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
No linked issue: found while reviewing NanoForge-dev/workspace#11. ADR 0010 (workspace) already planned to drop this dependency.
It removes the
@nanoforge-dev/actionsdevDependency frompackage.jsonand thepnpm-workspace.yamlcatalog. This repo doesn't use it:tests.yml, runs checkout, setup-node, install, lint, validate, broken-links and a11y;docs-syncaction of the source repos, which they call by action ref, not through this package.The lockfile loses
@nanoforge-dev/actions@2.0.0and the packages only it pulled in:@actions/*, two@octokit/plugin-*,tunnelandundici@6. The@octokitpackages other dependencies still use stay. pnpm also refreshed onedeprecatednote ongit-raw-commits, which changes nothing that gets installed.How do you test this PR?
pnpm install --frozen-lockfilepasses and leaves the lockfile unchanged.pnpm lintpasses ("All matched files use Prettier code style!").git grep "nanoforge-dev/actions"finds no use left outside the lockfile.pnpm validateandpnpm broken-links, because mint refuses Node 26 (the repo requires 24). The PR'stests.ymlruns them.Merge danger
Door: two-way. It removes a devDependency and changes no site content.
Blast radius: this repo's install. Merging redeploys the docs site with the same pages.
Follow-up issues
None filed. Candidates from the review:
changelogscript points to a missingcliff.toml, andreleaserunscliff-jumperwith no config;src/folder that doesn't exist, and eslint isn't installed.Quality gate
deprecatedmetadata line), kept