Skip to content

Support 2025 TMYx EPW design condition records - #5678

Draft
joseph-robertson wants to merge 2 commits into
developfrom
epw-tmyx-2025
Draft

joseph-robertson wants to merge 2 commits into
developfrom
epw-tmyx-2025

Conversation

@joseph-robertson

@joseph-robertson joseph-robertson commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Pull request overview

Fixes #5677:

  • Parse the extended Extremes layout, including its 12 wetbulb statistics, and expose those values through the design condition API.
  • Normalize records that omit the blank separator before Heating, while retaining support for existing EPW field layouts.
  • In heuristic fallback, classify a 16-field Heating / 27-field Extremes record as 2025 only when the blank before Heating is missing; with the blank present, it falls back to 2021.
  • Add regression coverage for titled, titleless, and misleading title records, plus loading a complete EPW file.

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson self-assigned this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Design conditions not parsed for TMYx EPW

1 participant