fix(android): inset modal close button below status bar - #83
Open
jsdatarocks wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Keeps the Android modal close button below the status bar by applying the current status bar inset to its header row before the existing
8.dpcontent padding.Problem
Android modals are rendered as full-screen Compose dialogs with
decorFitsSystemWindowsdisabled. When a modal is dismissible, its close-button row previously used only a fixed8.dppadding and did not account for the status bar inset.On edge-to-edge windows, this could place the close button inside the status bar area instead of within the modal's usable content area. The result varies with the device's status bar inset, so the control could appear misplaced or overlap system UI.
Changes
statusBarsPadding()to the dismissible modal header row on Android.8.dppadding, preserving the intended spacing inside the safe content area.Dependency and rollout
This is a self-contained Android layout fix. It introduces no new public API, configuration, or dependency requirements and can be reviewed and released independently.