Repository navigation
fix(houdini): OpenCode for Houdini 0.3.1, the panel's first Connect waits for its folder's Location and says why a Connect failed - #34
Merged
Conversation
…aits for its folder's Location and says why a Connect failed
The Gaffer trial found that the panel's first Connect fails in a folder
OpenCode has never opened: the panel's conversation lives in the hip's
folder, a Location the service opens on that first Connect, and the
panel's first call to the integration's RPC there ("RPC is unavailable:
neuralnomads.houdini") comes before OpenCode has loaded its plugins. The
panel said only "Connection or action failed", which read as another
conversation attached to the same Houdini holding it; there is no such
lock, and a second Connect worked. Houdini's panel had the same search
and the same message.
As in Gaffer's panel, an unavailable RPC while looking for this
Houdini's offer is now read as a Location still loading and asked again
within the offer wait, raised from 8 s to 30 s. A Connect that fails
says which step failed (reaching OpenCode, creating the file's
conversation, finding the offer, attaching) and the error's first line,
without a token, an authorization or a port; another panel action says
its error the same way. The search and the step wording move to
sidecar-steps.ts, which needs no OpenCode client and is tested alone.
OpenCode for Houdini and OpenCode Link become 0.3.1; the plugin expects
OpenCode Link ^0.3.1, as each patch release does, so updating the plugin
asks to update OpenCode Link.
Tests: sidecar-steps.test.ts finds the offer after two unavailable
answers, stops at another error or at the deadline, and names the failed
step without credentials. Real trial with the real OpenCode service and
a windowed Houdini 22.0.429 on a hidden desktop, private preferences, a
conversation attached first to a hip in a folder OpenCode had never
opened: OpenCode Link 0.3.0 reproduced the failure ("Connection or action
failed", a second Connect worked); 0.3.1 connected on the first Connect
in 2 s. Closing the panel kept the other conversation attached, detaching
that conversation kept the panel connected, and attaching it again said
"shared".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same fix as Gaffer's panel (#33, 8b97953), for Houdini's panel.
Cause. The panel's conversation lives in the hip's folder, a Location the OpenCode service opens on the first Connect there. The panel's first call to the integration's RPC in that Location ("RPC is unavailable: neuralnomads.houdini") came before the service had loaded its plugins, and the panel said only "Connection or action failed". This looked like another conversation attached to the same Houdini holding it. There is no such lock, and a second Connect worked.
Change.
sidecar-steps.ts, tested on their own.^0.3.1, as every patch release does (catalogue updated too), so users who update the plugin are asked to update OpenCode Link.Validation.
sidecar-steps.test.ts: the offer is found after two unavailable answers; the search stops at another error or at the deadline; the failed step is named without credentials.npm testran 329 tests, 322 passed, 0 failed, 7 skipped (real-application tests).