Declare nemar_id for 15 datasets whose NEMAR deposits are now public - #1145
Merged
Merged
Conversation
Each of these carried a placeholder:
# nemar_id = "nm000174" pending: NEMAR deposit not yet public
The deposits are public now and publish sourcedata/, so the placeholders are
uncommented. Without the attribute, #1139's provider cannot reach them:
sourcedata_path() raises 'declares no nemar_id' and 'auto' silently falls back
to the upstream host -- which for several of these is the slow or bot-gated
source the NEMAR mirror exists to route around.
Every pair was verified against the live deposit rather than a local mapping:
each is published, carries sourcedata/, and its sourcedata_provenance.json
records the same MOABB class. Two entries in our own mapping table were wrong
in exactly this way before (Chailloux2020 pointed at a duplicate of on003190,
TrianaGuzman2024 at a deposit the admins denied), which is why the check is
against the deposit and not the table.
Verified end-to-end with the provider pinned to 'nemar': Nguyen2017_V (8
files), Pressel2016 (15) and Kaneshiro2015 (10) now download and every file
hashes to the sha256 recorded from the original upstream fetch. Nguyen2017_V
previously failed with 'declares no nemar_id'.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1139. That PR added the NEMAR download provider; this makes it actually reach 15 more datasets.
Each of these already carried a placeholder:
# nemar_id = "nm000174" pending: NEMAR deposit not yet publicThose deposits are public now and publish
sourcedata/, so the placeholders are simply uncommented — 15 lines, no logic change.Why it matters
Without the attribute the provider cannot see them.
sourcedata_path()raisesdeclares no nemar_id, and"auto"silently falls back to the upstream host — which for several of these is precisely the slow or bot-gated source the mirror exists to route around.Measured before this change: 120 enriched deposits were reachable, 15 were not. All 15 were enriched in the last few days, after the mapping was last updated.
Verification
Every pair checked against the live deposit, not a local table. For each: the deposit is published, carries
sourcedata/, and itssourcedata_provenance.jsonrecords the same MOABB class. This mattered — two entries in our own mapping table were wrong in exactly this way (Chailloux2020pointed at a duplicate ofon003190,TrianaGuzman2024at a deposit the NEMAR admins had denied), so checking the table against itself would have propagated those errors.End-to-end with the provider pinned to
nemar:Nguyen2017_VPressel2016Kaneshiro2015Nguyen2017_Vpreviously failed withdeclares no nemar_id; it now downloads. Every file hashes to the sha256 recorded from the original upstream fetch at staging time, so the served bytes equal the upstream bytes.Separately, a checksum cross-check over a 20-deposit sample compared 2,719 files between each published manifest and its provenance — zero mismatches.
Note for a follow-up (not this PR)
nemar-pylogsprimary backend failed; falling back to next layeron every fetch, because small git-keyed files (README.md,sourcedata_provenance.json) have no annex checksum for the S3 backend to use. It recovers correctly, but a routine fallback reading as a failure makes real failures harder to spot.