fix(ruby): classify missing consumers - #331
Conversation
|
Real-user verification evidence The original RED is retrospective because implementation and tests were committed together. Running the final classification test with the base library produced 3 runs, 3 assertions, 3 failures: each path raised generic PGQUE_TEST_DSN=postgresql:///pgque_pr_rules_audit \
ruby -Iclients/ruby/lib -Iclients/ruby/test \
clients/ruby/test/test_consumer_not_found.rb
PGQUE_TEST_DSN=postgresql:///pgque_pr_rules_audit ruby -S rake test
gem build pgque.gemspec --output /tmp/pgque-331-0.3.0.rc.1.gemFocused head result: 3 runs, 20 assertions, 0 failures. Full database result: 79 runs, 212 assertions, 0 failures, 0 errors, 0 skips. An isolated installed gem confirmed |
NikolayS
left a comment
There was a problem hiding this comment.
REV rubric review
Automated ultrareview quota was unavailable, so I executed the five official
REV rubric prompts manually. SOC2 findings were omitted as instructed. This is
a comment-only review, not an approval.
Blocking findings
None. I found no unresolved functional, security, documentation, or test
blocker on head 36958af560593cdc698251c85b7713812833ea32.
Rubric results
- Bug hunter: all known missing-consumer server messages map to
ConsumerNotFound; queue and batch classifications retain their ordering. - Security reviewer: classification is local to trusted server error text and
introduces no SQL, privilege, or information-disclosure path. - Docs reviewer: this repairs behavior of an existing public exception class;
no new setup or user workflow needs separate documentation. - Guidelines checker: the PR is one surgical fix, title/commit use an allowed
type, the subject is under 50 characters, and all CI checks pass. - Test analyzer: direct, cooperative, and real-Postgres paths are covered;
tests also assert preservation of the originalPG::Errorcause and
backtrace. Recorded base failures and head successes provide RED/GREEN
evidence.
Nonblocking findings
None from the manual rubrics. No code change is requested by this review.
Summary
Pgque::ConsumerNotFoundPG::Errorcause and backtraceFixes #315.
Validation
3 runs, 3 assertions, 3 expected failures3 runs, 20 assertions, 0 failures79 runs, 212 assertions, 0 failures, 0 errorsgit diff --checkpassed