Skip to content

chore: pin third-party actions to commit SHAs - #320

Merged
erwan-joly merged 1 commit into
masterfrom
harden/pin-third-party-actions
Sep 10, 2026
Merged

chore: pin third-party actions to commit SHAs#320
erwan-joly merged 1 commit into
masterfrom
harden/pin-third-party-actions

Conversation

@erwan-joly

@erwan-joly erwan-joly commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Pins every non-GitHub-owned action in this repo to a full-length commit SHA, keeping the version tag as a trailing comment.

A tag is a moving pointer — whoever controls the upstream repo (or compromises that maintainer's account) can repoint it and change what executes here. These steps run with contents: write or cloud credentials in scope, so that matters.

No version changes: each SHA is the exact commit the pinned tag resolved to today. Part of a sweep across the org so sha_pinning_required can be turned on afterwards.

Summary by CodeRabbit

  • Chores
    • Improved release reliability by pinning the release automation to a specific, verified version.

Tags are mutable, so a moved tag silently changes what runs in CI. The
version each SHA came from is kept as a trailing comment.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 0491ad5d-5201-4358-9ec0-75cffff491cc

📥 Commits

Reviewing files that changed from the base of the PR and between 023ef9d and 272cc2c.

📒 Files selected for processing (1)
  • .github/workflows/dotnet.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The release job now references softprops/action-gh-release by commit SHA instead of the mutable v3 tag.

Changes

Release workflow

Layer / File(s) Summary
Pin release action
.github/workflows/dotnet.yml
The release job pins softprops/action-gh-release to commit efb35369e0ad2afab669f228072c1b0d510eae64 and retains the v3 version comment.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 272cc

The release workflow keeps the same action version while preventing mutable-tag changes, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: pinning third-party GitHub Actions to commit SHAs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch harden/pin-third-party-actions

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@erwan-joly
erwan-joly merged commit 0745a8d into master Sep 10, 2026
4 checks passed
@erwan-joly
erwan-joly deleted the harden/pin-third-party-actions branch September 10, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant