chore: remove the dead ECS deploy

[erwan-joly]

The deploy steps in this workflow target ECS cluster discordbot-cluster, which does not exist. I enumerated every ECS cluster in all 17 regions of the account; the only one is secretpull.

So these steps cannot have succeeded for some time, while still pulling AWS_ACCESS_KEY_ID / AWS_SECRET_ACCESS_KEY into the job on every push to master. Those are organisation-level secrets, and the key behind them carries AdministratorAccess over the whole shared side-project account — Winpixies, secretpull, NosCoreLegend, cardscanner. A credential that broad, in a job that achieves nothing, is pure downside.

Removes the three deploy steps. Build and tests are untouched.

NosCoreLambdas gets the same treatment for the same reason (its noscore-travis Lambda is also gone). Once both merge, nothing in the org references those secrets and they can be deleted outright — which closes the finding without needing a key rotation.

If the bot is ever revived, the replacement should be an OIDC role scoped to repo:NosCoreIO/NosCoreBot with ECR push on noscorebot and nothing else.

Summary by CodeRabbit

• Changes
  • Production deployment automation has been removed.
  • The workflow now focuses on restoring dependencies, building the application, and running unit tests.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7f1f641d-627b-49f0-a596-37381c724d92

📥 Commits

Reviewing files that changed from the base of the PR and between e8ce991 and cebe430.

📒 Files selected for processing (1)

• .github/workflows/dotnet.yml

💤 Files with no reviewable changes (1)

• .github/workflows/dotnet.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The workflow removes production deployment actions from the .NET build job. It now performs dependency restore, compilation, and unit tests for all branches.

Changes

CI workflow

Layer / File(s)	Summary
Retain validation and remove deployment .github/workflows/dotnet.yml	The workflow retains dotnet restore, dotnet build, and dotnet test. AWS credential setup, ECR login, Docker image publishing, and ECS deployment steps are removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to cebe4

The workflow continues validating the .NET project while removing obsolete production deployment actions and unnecessary administrator credentials. No merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: removing the obsolete ECS deployment workflow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch harden/remove-dead-aws-deploy

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}