Update GraphQL to version 26.1 - #9
Open
matthewwilson-nosto wants to merge 1 commit into
Open
matthewwilson-nosto wants to merge 1 commit into
matthewwilson-nosto wants to merge 1 commit into
Conversation
Bumps com.graphql-java:graphql-java from 21.5 to 26.1 and fixes the resulting binary/behavioral incompatibilities: - AnnotationsSchemaCreator: additionalType/additionalTypes now require GraphQLNamedType instead of GraphQLType. - CodeRegistryUtil: GraphQLCodeRegistry.Builder.getDataFetcher needs a FieldCoordinates, not a raw GraphQLFieldsContainer. - EnhancedExecutionStrategy: resolveField no longer exists as an override point; the clientMutationId interception moves into completeValue, and ExecutionContext.getVariables() is replaced by getCoercedVariables(). - DirectivesBuilder: directive argument values must be coerced via serialize() rather than parseValue(), which became stricter about rejecting String literals for non-String scalars. Also fixes tests that broke for the same reasons (stricter GraphQLDirective location validation, and graphql-java's internal list type no longer being a concrete ArrayList). Verified with the full existing test suite (243/243 passing, matching the pre-upgrade baseline). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
com.graphql-java:graphql-javafrom21.5to26.1and fixes the resulting incompatibilities so the fork actually works against the new version. This is needed to unblock playcart's owngraphql-javaupgrade (ADS-5303), which depends on this fork.Type
Checklist
Notes for reviewers
EnhancedExecutionStrategychanged the most - the oldresolveFieldoverride is now gone and I've moved the logic intocompleteValue.