Skip to content

fix(auth): [FDE-1873] redeem browser login with callback secret - #167

Draft
jridey-nullify wants to merge 1 commit into
mainfrom
patch/cli-browser-redemption
Draft

jridey-nullify wants to merge 1 commit into
mainfrom
patch/cli-browser-redemption

Conversation

@jridey-nullify

@jridey-nullify jridey-nullify commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Codex

Browser login failed against the hardened auth API because the CLI discarded the callback's redemption secret.

  • Validate the callback session and a single 64-character hexadecimal secret before accepting it.
  • Send the secret with the session ID when redeeming tokens; reject malformed callbacks without consuming a valid retry.
  • Deliver concurrent callbacks once and prevent callback-response caching.
  • Replace premature browser success with an acknowledgement directing users to the terminal.
flowchart LR
    B["Browser completes login"] --> C["Localhost callback validates session and secret"]
    C --> R["Changed: CLI sends both values to token endpoint"]
    R --> S["Store credentials after successful redemption"]
Loading

Companion backend: https://github.com/Nullify-Platform/nullify/pull/13493.

Live radiant verification: the installed 0.25.3 client failed with missing redemption_secret; this build completed browser login and an authenticated repos read against the updated backend.

@jridey-nullify jridey-nullify added the patch Patch version updates (fixes) label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Patch version updates (fixes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant