Repository navigation
fix(auth): [FDE-1873] redeem browser login with callback secret - #167
Draft
jridey-nullify wants to merge 1 commit into
Draft
jridey-nullify wants to merge 1 commit into
jridey-nullify wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser login failed against the hardened auth API because the CLI discarded the callback's redemption secret.
flowchart LR B["Browser completes login"] --> C["Localhost callback validates session and secret"] C --> R["Changed: CLI sends both values to token endpoint"] R --> S["Store credentials after successful redemption"]Companion backend: https://github.com/Nullify-Platform/nullify/pull/13493.
Live radiant verification: the installed 0.25.3 client failed with missing
redemption_secret; this build completed browser login and an authenticatedreposread against the updated backend.