Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
b6649a8 to
6748713
Compare
|
@dhongu Please, add commits history like https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-20.0 |
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Thanks @dhongu for working on this!
While testing, I found that clicking another job in the Dependencies tab raises an error because get_formview_action() was removed in Odoo 20.0.
Fix: build the form action directly in JS instead of asking the server, then pass it to this.action.doAction(). I tried this locally and the click opens the job correctly.
micheledic
left a comment
micheledic
left a comment
There was a problem hiding this comment.
Adding to this, you should preserve the full history.
There was a problem hiding this comment.
| "get_record_default_action", |
Odoo 19 renamed Field._setup_attrs to _setup_attrs__, so the override was no longer called and an unsupported base_type was silently accepted.
The failure is handled from a temporary cursor while the failed job's transaction still holds its locks: an on fail hook writing on the same records waited forever. Perform the job in a savepoint so that its locks are released when it fails.
odoo shell starts the server with stop=True and stops it right away, so the runner thread was started for nothing and its START_DELAY made every shell wait 5 seconds before the prompt. Core already skips its HTTP and cron threads when stop is set; the runner now follows the same rule.
- ir.model.access + ir.rule -> ir.access - registry.clear_cache -> transaction.invalidate_ormcache - controller: use odoo.sql_db.PG_CONCURRENCY_EXCEPTIONS_TO_RETRY (odoo.service.model was removed); env.clear() -> env.transaction.clear() - jobrunner: odoo.modules.db.list_dbs (odoo.service.db was removed) - fields: _setup_attrs -> _setup_attrs__; tools.ormcache -> api.ormcache - JS: job_direct_graph widget ported to Owl 3 (useProps, signal ref); get_formview_action -> get_record_default_action (removed in 20.0) - views: remaining_days widget -> relative_date; stat button icon - tests: odoo.http.Request -> odoo.http.requestlib.Request - lint fixes required by the 20.0 template (ruff 0.16, pylint-odoo 10) Co-authored-by: Jared Kipe <jared@hibou.io> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6748713 to
2b08ccd
Compare
|
Thanks for the reviews, both points are addressed:
|
|
You shouldn't add the AI agent as a co-author. It should be mentioned as assisted by AI according to the OCA AI policy: https://github.com/OCA/.github/blob/master/AI_POLICY.md |
8 participants
Migration of
queue_jobto Odoo 20.0.Main changes:
ir.model.access+ir.rule→ir.accessregistry.clear_cache→transaction.invalidate_ormcacheodoo.sql_db.PG_CONCURRENCY_EXCEPTIONS_TO_RETRY(odoo.service.modelwas removed);env.clear()→env.transaction.clear()odoo.modules.db.list_dbs(odoo.service.dbwas removed)_setup_attrs→_setup_attrs__;tools.ormcache→api.ormcachejob_direct_graphwidget ported to Owl 3 (useProps, signal ref)remaining_dayswidget →relative_date; stat button iconodoo.http.Request→odoo.http.requestlib.Request# noqa: DTZ005ondatetime.now()because Odoo stores naive UTC datetimesTested locally on Odoo 20.0 with PostgreSQL 16: the module installs and all 54
queue_jobtests pass.pre-commit run -ais clean.This PR also includes the work prepared by @jaredkipe in #997 (co-authored).
test_queue_joband the other addons will follow in separate PRs.🤖 Generated with Claude Code