Skip to content

[IMP] fastapi: As we have route_group, we could use it - #634

Open
etobella wants to merge 1 commit into
OCA:19.0from
dixmit:19.0-group
Open

[IMP] fastapi: As we have route_group, we could use it#634
etobella wants to merge 1 commit into
OCA:19.0from
dixmit:19.0-group

Conversation

@etobella

Copy link
Copy Markdown
Member

This allows us to set the route_group.

Really interesting in conjunction with OCA/web-api#149

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@lmignon

lmignon commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Thank you for the proposal @etobella It's interesting. Nevertheless. The field you add to the fastapi addon is useless while the the endpoint_route_handler_filter is not installed. It therefore depends on the endpoint_route_handler_filter addon. Since it depends on an additional addon, I prefer to declare-it into a glue addon to keep a fine grained approach and ease traceability.

@etobella

Copy link
Copy Markdown
Member Author

I understand your comment @lmignon , however, the field is defined in the dependency, the change is 4 lines of code and it has no effect (2 additions and 2 changes). Also, with the configuration of endpoint_route_handler, it was expected that fastapi should send it. If we add a new module, we are adding much more code to the code base (around 500 probably between readmes, html and so on, only in python and xml it will be around 50 at least) for something that has no harm if we have it in the main module and should be there.

Evenmore, if we want a new module we require a change in this module to add a hook, so the code added in the code base is similar (1 edition at least and 3-4 additions of the hook function)

If you want, we can make this field hidden in the view if the problem is visual, but adding it is minimal and has no harm.

Please reconsider it to avoid adding too much code in the database.

@CristianoMafraJunior CristianoMafraJunior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants