[IMP] fastapi: As we have route_group, we could use it - #634
Conversation
|
Hi @lmignon, |
|
Thank you for the proposal @etobella It's interesting. Nevertheless. The field you add to the fastapi addon is useless while the the endpoint_route_handler_filter is not installed. It therefore depends on the |
|
I understand your comment @lmignon , however, the field is defined in the dependency, the change is 4 lines of code and it has no effect (2 additions and 2 changes). Also, with the configuration of endpoint_route_handler, it was expected that fastapi should send it. If we add a new module, we are adding much more code to the code base (around 500 probably between readmes, html and so on, only in python and xml it will be around 50 at least) for something that has no harm if we have it in the main module and should be there. Evenmore, if we want a new module we require a change in this module to add a hook, so the code added in the code base is similar (1 edition at least and 3-4 additions of the hook function) If you want, we can make this field hidden in the view if the problem is visual, but adding it is minimal and has no harm. Please reconsider it to avoid adding too much code in the database. |
This allows us to set the route_group.
Really interesting in conjunction with OCA/web-api#149