Repository navigation
Conversation
superwhiskers
left a comment
There was a problem hiding this comment.
i've run the test locally, it passes. this is a significant improvement over the previous implementation ergonomically, so i think it's ready to merge once these comments are addressed
|
@superwhiskers Thank you for the suggestions I think this model is very clean, now. one of the cleaner implementations, too Notice that the target branch is #566, not develop! That is intended to merge first since I used it here |
pelesh
left a comment
There was a problem hiding this comment.
A few nits but I think this is good to merge.
| if (q != RealT{0}) | ||
| { | ||
| return 2; | ||
| } | ||
| if (p != RealT{0}) | ||
| { | ||
| return 1; |
There was a problem hiding this comment.
I really don't like such floating point comparisons. Can't we use model "order parameter" to set these values to zero?
There was a problem hiding this comment.
No, I strongly feel that we should not have an order parameter exposed that way. It would require intimate knowledge of the implementation to change the parameters. This is a common enough model that it would cause real usability friction IMO.
is there a way we can do this safely? There must be a way to actually compare against zero, if that's truly the intended comparison.
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
880ff13 to
da64037
Compare
Co-authored-by: superwhiskers <whiskerdev@protonmail.com>
d5b7b78 to
b0d2790
Compare
Co-authored-by: pelesh <peless@ornl.gov>
pelesh
left a comment
There was a problem hiding this comment.
I will temporarily block merging this as it requires more offline discussion.
8a4dbbb to
fdff03b
Compare
Description
Templates
Ieeeston its notch order, derived from the notch coefficients, so each order has only its own states and a branch-free residual.Depends on #566. Supersedes #460.
Proposed changes
Ieeest<ScalarT, IdxT, order>andIeeestFactory, which derives the order fromA1–A4.ParameterReaderand check them withConfigurationChecks.VariableMonitoraccept models with extra template parameters.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
Zero lag time constants are now raised to 1 ms instead of bypassed, so that time constants are treated identically for all models. All validation cases containing IEEEST still pass. We could apply this model's approach in the future to the others to resolve any issues time constant might be contributing to #463
@superwhiskers @nkoukpaizan @pelesh I have consolidated all past reviewer comments when considering this final implementation for IEEEST, so your feedback was much appreciated in the superseded PRs.