Repository navigation
Conversation
jekuaitk
force-pushed
the
feature/312-report-misconfigured-handlers
branch
2 times, most recently
from
July 13, 2026 14:02
f2c7ff8 to
dfb89e7
Compare
jekuaitk
force-pushed
the
feature/312-report-misconfigured-handlers
branch
from
July 13, 2026 14:33
dfb89e7 to
902f14f
Compare
cableman
requested changes
Jul 15, 2026
cableman
self-requested a review
July 16, 2026 08:25
cableman
approved these changes
Jul 16, 2026
stankut
requested changes
Oct 14, 2026
stankut
left a comment
stankut
left a comment
Collaborator
There was a problem hiding this comment.
looks good, but few questions
| */ | ||
| public function validateForm(array &$form, FormStateInterface $form_state) { | ||
| $subform_state = SubformState::createForSubform($form['settings'], $form, $form_state); | ||
| $this->handler->validateConfigurationForm($form, $subform_state); |
Collaborator
There was a problem hiding this comment.
since we are working with $form['settings'], should we validate it instead of the entire form?
e.g.
$this->handler->validateConfigurationForm($form['settings'], $subform_state);
Contributor
Author
There was a problem hiding this comment.
Some handlers index specific values in the entire form, i.e. ScheduleEmailWebformHandler::validateConfigurationForm setting errors on $form['settings']['scheduled']['send'].
| public function buildForm(array $form, FormStateInterface $form_state) { | ||
| // Build the handler configuration form the same way as | ||
| // \Drupal\webform\Form\WebformHandlerFormBase::form(). | ||
| $form['settings'] = []; |
Collaborator
There was a problem hiding this comment.
Drupal implementation of it looks like this https://git.drupalcode.org/project/webform/-/blob/HEAD/src/Form/WebformHandlerFormBase.php#L201-205:
$form['#parents'] = [];
$form['settings'] = [
'#tree' => TRUE,
'#parents' => ['settings'],
];
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ations
https://leantime.itkdev.dk/#/tickets/showTicket/7971
#312
and handlers pages, based on programmatically validating handler
configuration forms.
dangling element references no longer display as valid configuration.
Note
The failing check is unrelated to changes made in this PR and should be solved in a separate PR.
Example misconfigured handler messages