Skip to content

Computed twig encryption fix - #380

Merged
stankut merged 2 commits into
developfrom
f/computed-twig-encryption
Nov 2, 2026
Merged

Computed twig encryption fix#380
stankut merged 2 commits into
developfrom
f/computed-twig-encryption

Conversation

@stankut

@stankut stankut commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@ds-bellcom ds-bellcom linked an issue Oct 26, 2026 that may be closed by this pull request
Kan ikke sende digital post efter installation af OS2Forms Encrypt #374
Closed
@ds-bellcom ds-bellcom mentioned this pull request Oct 26, 2026
Closed
jekuaitk
jekuaitk approved these changes Oct 28, 2026
View reviewed changes

@jekuaitk jekuaitk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the full overview of the necessity of this, but as long as it is tested im ok with it!

@jekuaitk

jekuaitk commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Turns out it is also needed for checkboxes since it's value is either the integer 0 or 1.

@stankut

stankut commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator Author

@jekuaitk do you have an example how to test it, or that problem it is giving?

@jekuaitk

jekuaitk commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

@jekuaitk do you have an example how to test it, or that problem it is giving?

Submitting https://test.os2forms.dk/da/form/jekua-issue-374 shows the issue we were running into after upgrading to Drupal 11 on a staging site.

TypeError: ParagonIE\HiddenString\HiddenString::__construct(): Argument #1 ($value) must be of type string, int given...

@stankut

stankut commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator Author

@jekuaitk i can see that the fix we made have been overwritten on test.os2forms.dk

i have added it back and the issue you raised is no longer there:
https://test.os2forms.dk/da/form/jekua-issue-374

@stankut
stankut merged commit 77cd59a into develop Nov 2, 2026
8 checks passed
@stankut
stankut deleted the f/computed-twig-encryption branch November 2, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jekuaitk jekuaitk jekuaitk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Kan ikke sende digital post efter installation af OS2Forms Encrypt

2 participants

@stankut @jekuaitk