ci: let the build be started by hand, not only by a pull request - #42
Merged
Conversation
Build PR ran on `pull_request` alone, and that turned out to be the only way to get a build at all. When feat/block-storage conflicted with main on 2026-08-02 at 21:07 UTC, GitHub stopped being able to form refs/pull/39/merge, and with no mergeable state no run was created -- not a failed one, not a skipped one, none. Both open PRs sat without CI for fifteen hours and nothing in the UI said why. The only workflow carrying workflow_dispatch was Benchmark, so there was no way to ask for a build and watch it fail. A manual trigger does not fix the conflict, but it makes the state visible instead of silent. force-build is tied to the event because the reusable workflow decides whether to build from a dorny/paths-filter comparison, and that comparison has no base outside a pull request. A run somebody started by hand is one they want regardless of what changed, so it skips the filter rather than depending on whatever the filter answers without a base. On a pull_request event the expression is false and the path filter keeps deciding exactly as before. Not verified yet, and it cannot be from a branch: GitHub reads workflow_dispatch only from the default branch, so the button does not appear for this workflow until this is merged. What to check afterwards is in the pull request. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGpJqdmh7ZNH487GLqPJmK
Contributor
Test results 201 files 201 suites 3m 50s ⏱️ Results for commit 33aa82e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Build PRtriggered onpull_requestalone, and that was the only path to a build.On 2026-08-02 at 21:07 UTC,
272cb0b3(#41) landed onmainand putFalcoLightingChunk.javainto conflict withfeat/block-storage. GitHub cannot formrefs/pull/N/mergefor a conflicted PR, and without a mergeable state no run is created at all — not failed, not skipped, absent. PRs #39 and #40 sat without CI for fifteen hours, and nothing on the Actions page said why. The only workflow carryingworkflow_dispatchwasBenchmark, so there was no way to ask for a build and watch it refuse.A manual trigger does not fix a conflict. It makes the state visible instead of silent.
What changed
on: [pull_request]becomespull_requestplusworkflow_dispatch, and the reusable workflow getsforce-buildtied to the event:The reusable workflow decides whether to build from a
dorny/paths-filtercomparison, and that comparison has no base outside a pull request. A run somebody started by hand is one they want regardless of what changed, so it skips the filter rather than depending on whatever the filter answers without a base. On apull_requestevent the expression isfalseand the path filter keeps deciding exactly as it does today — this PR changes nothing about automatic runs.Not verified, and why it cannot be from here
GitHub reads
workflow_dispatchonly from the default branch. The button does not appear for this workflow until this is onmain, so the manual path cannot be exercised from the branch. After merging, worth checking once:Build PRand accepts a non-default branchDetect changescompletes rather than erroring without a baseBuild (…)runs on all three runners despitecode=false— that isforce-builddoing its jobIf
Detect changeserrors instead of returningfalse,force-buildwill not save the run, becausebuildneedschangesand has noalways(). In that case the fix belongs in the org workflow, not here.