Repository navigation
fix: [SDK-5654] lay out IAMs for iPhone Duo and resizable scenes #1789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+225
−74
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f76f4dc
fix: [SDK-5654] render IAMs on iPhone Duo folded and unfolded
fadi-george 94b049f
chore: [SDK-5654] fill demo top inset with the nav bar color
fadi-george 4577de9
fix(iam): keep IAM clear of safe area hardware
fadi-george 3766b06
revert me later
fadi-george c98f33d
fix(iam): query full-screen window for occlusion regions
fadi-george 3a331d6
refactor(iam): extract sceneView helper method
fadi-george 262f921
fix(iam): use max of margin and bottom safe area
fadi-george 402c59c
fix(iam): apply safe area offset to top banners
fadi-george 220f9b6
refactor(iam): unify vertical insets via layout guide
fadi-george f4e829a
refactor(iam): compute webview insets before window exists
fadi-george eb4ac62
fix(iam): refresh status bar visibility once IAM appears
fadi-george 07301d4
Revert "revert me later"
fadi-george b1f8f27
fix(iam): look up reserved regions at runtime
fadi-george 9205fc8
fix(iam): prefer lowest visible full scene window for insets
fadi-george af88faa
refactor(iam): skip reserved regions for full screen messages
fadi-george 2333383
fix(iam): only refresh status bar for full screen messages
fadi-george 7827c0a
chore(iam): warn when display bounds fall back to the screen
fadi-george 52f0398
fix(iam): re-show message when JS height check fails on rotation
fadi-george 017a6ab
chore(iam): note when the reserved region shim can go
fadi-george eaa970c
fix(iam): send full screen insets from the message's own window
fadi-george File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking: The header declares
newHeightnon-null (it's underNS_ASSUME_NONNULL_BEGIN), but this passes nil.NSNumber * _Nullable newHeightin the .h would match the caller's nil check.