[php-nextgen] Fix Nested oneOf/anyOf Behavior#24318
Draft
ckoegel wants to merge 23 commits into
Draft
Conversation
…into php-nextgen-anyof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds off of work done in #24306. It flattens composed union type-hints transitively so a nested composed property resolves to its leaf members. Previously, composed property type-hints only listed their direct members, so when a composed type nested another composed type, the deserializer returned a leaf instance the property's union rejected and threw a TypeError.
Once #24306 is merged, I'll update this and mark as ready for review.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)
Summary by cubic
Adds proper
anyOfsupport and fixes nestedoneOf/anyOfdeserialization inphp-nextgenby flattening unions to leaf types and dispatching via dedicated interfaces. Updates templates, docs, serializer, tests, and samples to handle discriminators and arrays correctly.Bug Fixes
OneOfInterfaceand newAnyOfInterface;ObjectSerializernow callsdeserializeOneOf/deserializeAnyOfbefore array-to-object casting.oneOf/anyOfunions transitively so properties and docs use leaf member types, including discriminator cases.anyOfwrappers withmodel_anyof.mustacheandAnyOfInterface.mustache; updatemodel_doc.mustacheand test templates to reflect composed behavior; add generator tests and sample models.Migration
OneOfInterface;AnyOfInterfaceis new foranyOfwrappers. Regenerate clients.Written for commit 1582a69. Summary will update on new commits.