[JAVA-SPRING;KOTLIN-SPRING]: honor useTags=false for HTTP interface libraries - #24862
Draft
Picazsoo wants to merge 2 commits into
Draft
[JAVA-SPRING;KOTLIN-SPRING]: honor useTags=false for HTTP interface libraries#24862Picazsoo wants to merge 2 commits into
useTags=false for HTTP interface libraries#24862Picazsoo wants to merge 2 commits into
Conversation
- SpringCodegen: include spring-http-interface in supportLibraryUseTags() so useTags=false groups operations by first path segment instead of tag. - KotlinSpringServerCodegen: include spring-declarative-http-interface in the addOperationToGroup path-grouping condition alongside spring-boot. spring-cloud was deliberately left out of this condition since useTags defaults to false there and changing it would alter existing default grouping behavior for that library. - Add regression tests covering useTags=false/true grouping for both spring-http-interface and spring-declarative-http-interface. - Update two pre-existing kotlin-spring tests whose expected output filenames assumed the old (buggy) tag-based grouping for spring-declarative-http-interface. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
useTags=false for HTTP interface libraries
…P interface; update samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Fixes
useTags=falsebeing ignored for Spring HTTP interface libraries so operations group by first path segment instead of tag.spring-http-interfaceandspring-declarative-http-interfaceto the path-grouping condition.another-fakebecomesanotherFake).spring-cloudunchanged becauseuseTagsdefaults to false there, and altering it would change existing grouping behavior.useTags: "true"forspring-http-interface.Written for commit ca5a862. Summary will update on new commits.