Repository navigation
Modernize Python version support in python-pydantic-v1 generator #25350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d0ed6fb
0c5c86c
15cb94b
568d5ef
60f8fd6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -13,7 +13,7 @@ jobs: | |||||
| runs-on: ubuntu-latest | ||||||
| strategy: | ||||||
| matrix: | ||||||
| python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] | ||||||
| python-version: ["3.11", "3.12", "3.13", "3.14"] | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P1: This matrix now runs the pydantic-v1 client on Python 3.14, but the repository’s pydantic-v1 integration workflow explicitly excludes 3.14. Remove 3.14 here until the pydantic-v1 dependency is compatible, otherwise every run of this generated workflow adds a known failing job. Prompt for AI agents
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is an issue with the workflow, which currently excludes Python 3.14. As I mentioned in this comment I think we should support Pydantic v1 on Python 3.14. |
||||||
|
|
||||||
| steps: | ||||||
| - uses: actions/checkout@v4 | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: https://pydantic.dev/docs/validation/1.10/overview/
shall we exclude 3.14 in this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I was thinking that since Pydantic v1 supports Python 3.14, we should support it too.
However, Python 3.15 is not supported.
See: pydantic/pydantic#13173 (comment)
Also, Pydantic v1.10.26 is the latest release that supports Python 3.14:
https://github.com/pydantic/pydantic/blob/v1.10.26/pyproject.toml#L24