Skip to content

ci: update Julia sample workflow to use the exact OpenAPI release-0.2 checkout - #25391

Open
Mattias-Sehlstedt wants to merge 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:update-julia-sample-task-definition
Open

Mattias-Sehlstedt wants to merge 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:update-julia-sample-task-definition

Conversation

@Mattias-Sehlstedt

Copy link
Copy Markdown
Contributor

An attempt to resolve build issues faced in #25383, where the task fails with:

ERROR: Compat HTTP not listed in deps or extras section

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@Mattias-Sehlstedt
Mattias-Sehlstedt marked this pull request as ready for review October 24, 2026 15:34

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Re-trigger cubic

@wing328

wing328 commented Oct 24, 2026

Copy link
Copy Markdown
Member

thanks for the PR

cc @tanmaykm

@tanmaykm tanmaykm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! The changes look good to me.

Noticed a small defect in the workflow trigger that existed from before - the workflow only runs when the Julia sample folders change, so it didn't run on this PR that changed only .github/workflows/samples-julia.yaml, I ran it locally to verify. It can be fixed in a different PR though, so not insisting for that here.

@Mattias-Sehlstedt
Mattias-Sehlstedt force-pushed the update-julia-sample-task-definition branch from 04771ad to 20b801f Compare October 24, 2026 19:02
@Mattias-Sehlstedt

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback. I have included a specification change that should hopefully trigger the sample generation. Having it occur in the PR itself will make it more clear that the change in the task has the intended result

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants