Repository navigation
ci: update Julia sample workflow to use the exact OpenAPI release-0.2 checkout - #25391
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
Mattias-Sehlstedt wants to merge 1 commit into
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
Mattias-Sehlstedt
marked this pull request as ready for review
October 24, 2026 15:34
Member
|
thanks for the PR cc @tanmaykm |
tanmaykm
approved these changes
Oct 24, 2026
tanmaykm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for picking this up! The changes look good to me.
Noticed a small defect in the workflow trigger that existed from before - the workflow only runs when the Julia sample folders change, so it didn't run on this PR that changed only .github/workflows/samples-julia.yaml, I ran it locally to verify. It can be fixed in a different PR though, so not insisting for that here.
Mattias-Sehlstedt
force-pushed
the
update-julia-sample-task-definition
branch
from
October 24, 2026 19:02
04771ad to
20b801f
Compare
Contributor
Author
|
Thanks for the feedback. I have included a specification change that should hopefully trigger the sample generation. Having it occur in the PR itself will make it more clear that the change in the task has the intended result |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to resolve build issues faced in #25383, where the task fails with:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.