Skip to content

refactor: move discriminator descendant calculation to utility method - #25399

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:move-discriminator-descendant-calculation-to-util
Oct 25, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
Mattias-Sehlstedt:move-discriminator-descendant-calculation-to-util

Conversation

@Mattias-Sehlstedt

Copy link
Copy Markdown
Contributor

Moves isolated and distinct discriminator logic from the DefaultCodegen to the dedicated DiscriminatorUtils helper. After this change there are three main discriminator-only methods left, createDiscriminator, getAllOfDescendants and getOneOfAnyOfDescendants.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

@Mattias-Sehlstedt
Mattias-Sehlstedt force-pushed the move-discriminator-descendant-calculation-to-util branch from d8994ff to 1c9a5d6 Compare October 25, 2026 13:45
@wing328
wing328 merged commit 85f34dc into OpenAPITools:master Oct 25, 2026
15 checks passed
@wing328 wing328 added this to the 7.27.0 milestone Oct 25, 2026
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants