Conversation
|
I bumped the threshold to 4.5 and set a max |
|
Actually, having thought more about this, a value of around 3.5 is safest. I've also updated the BioSimSpace and SOMD2 code to place an upper bound so that we don't end up with negative masses for heavy atoms. |
|
I've also added a warning for situations where the HMR factor produces a negative heavy atom mass. |
|
The tests appear to be failing due to a kartograph API change. I'll figure out what's changed and update. It might be that we need to add a pin. |
|
Despite the CI passing yesterday we are now seeing a repeated test failure for Linux Python 3.11 for a completely unrelated test (AMBER CMAP parsing). This is reproducible across CI runs. Will investigate on Monday. |
This PR closes #447 by increasing the maximum mass used to detect hydrogen atoms along with exposing a map option to tune the value.
@chryswoods: In case I'm missing something: Is there a reason why 2.5 was chosen? This does work with what would be used for the default SOMD1/SOMD2 HMR factor, but not in general.
Also closes #449 by considering both end states when adding initial entries to the
ghost-14force.Also closes #450 by constraining unperturbed heavy atom bonds, regardless of mass, matching SOMD1.
develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]