-
Notifications
You must be signed in to change notification settings - Fork 40
Create GraphQL service permission archtecture #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filiperochalopes
wants to merge
14
commits into
OpenConceptLab:master
Choose a base branch
from
filiperochalopes:feature/graphql-permissions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,539
−406
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
700cb8e
fix(graphql): align search behavior with REST for HEAD versions
filiperochalopes 08f2a45
chore: fix merge conflicts
filiperochalopes 5684b94
Merge branch 'master' of github.com:filiperochalopes/oclapi2
filiperochalopes 648799b
Merge branch 'master' of github.com:filiperochalopes/oclapi2
filiperochalopes 5cdc2ea
Merge branch 'master' of github.com:filiperochalopes/oclapi2
filiperochalopes 33a108d
feat(core/graphql): enforce repo visibility on searches
filiperochalopes fa0d5b5
feat(search): share concept query helpers across APIs
filiperochalopes a290ba8
feat(graphql): add structured error responses
filiperochalopes d68a349
chore: merge master and fix conflicts
filiperochalopes aa57dc9
refactor(permissions): centralize concept dictionary visibility logic
filiperochalopes b71715a
feat(graphql): improve concept search resiliency with database fallback
filiperochalopes 62f6b5c
Merge branch 'master' into feature/graphql-permissions
filiperochalopes b6ede0e
feat(graphql): add mapping sort weights, target names, and concept ex…
filiperochalopes 6eebc3c
feat(graphql): refactor search permissions and validation
filiperochalopes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this now never calls super and
HasPrivateAccessis dead codeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on the inheritance — CanViewConceptDictionary no longer calls super(), so the HasPrivateAccess base is meaningless here. Fixed by changing it to inherit from BasePermission directly.
Note:
HasPrivateAccessitself is still in use elsewhere (core/orgs/views.py:116,127,137, core/common/mixins.py:407, andCanEditConceptDictionarystill extends and calls super()), so the class is not dead globally — only the inheritance link from CanViewConceptDictionary was.