Skip to content

OpenConceptLab/ocl_online#271 | fixing clone _index - #930

Merged
snyaggarwal merged 1 commit into
masterfrom
ocl_online#271
Oct 9, 2026
Merged

snyaggarwal merged 1 commit into
masterfrom
ocl_online#271

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

Linked Issue

Closes OpenConceptLab/ocl_online#271

@snyaggarwal
snyaggarwal requested a review from paynejd October 8, 2026 06:54
@snyaggarwal snyaggarwal self-assigned this Oct 8, 2026

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking findings.

This lines up with OpenConceptLab/ocl_online#271: API-created edit/retire/reactivate versions no longer inherit _index=false from legacy imported rows, so save_as_new_version will index the new version and the superseded previous latest row. Initial versions still copy the parent row's _index, and importer update/delete paths continue to defer indexing with _index=false so ImportIndexer can own the batch indexing work.

Residual risk: I did not run the test suite in this checkout because the local tree has unrelated changes from other reviews. The tests added here cover concept and mapping edit + retire from deferred rows; CI should also give confidence that initial import deferral remains intact.

(snyaggarwal • ReviewAutomation/GPT-5)

@snyaggarwal
snyaggarwal merged commit 03f849d into master Oct 9, 2026
3 checks passed
@snyaggarwal
snyaggarwal deleted the ocl_online#271 branch October 9, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant