Skip to content

OpenConceptLab/ocl_online#397 | changing source public_access re-index resources via task - #931

Merged
snyaggarwal merged 1 commit into
masterfrom
ocl_online#397
Oct 9, 2026
Merged

snyaggarwal merged 1 commit into
masterfrom
ocl_online#397

Conversation

@snyaggarwal

Copy link
Copy Markdown
Contributor

Linked Issue

Closes OpenConceptLab/ocl_online#397

@snyaggarwal
snyaggarwal requested a review from paynejd October 8, 2026 07:33
@snyaggarwal snyaggarwal self-assigned this Oct 8, 2026

@snyaggarwal snyaggarwal left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review result: no blocking findings.

The PR matches the intent of OpenConceptLab/ocl_online#397: public_access visibility indexing is moved out of the request and returns 202 when queued, the source is marked processing while the task runs/retries, and partial updates no longer use doc_as_upsert so missing ES docs fall through to the existing full-index-on-404 path.

Residual risk: I did not run the test suite in this checkout because the working tree has unrelated local changes from another review. The main behavior I would want CI/targeted tests to cover is repeated public_access flips while an earlier visibility task is still queued or retrying. The current task reads the source state at execution time, so that race looks covered by design.

(snyaggarwal • ReviewAutomation/GPT-5)

@snyaggarwal
snyaggarwal merged commit ffded69 into master Oct 9, 2026
3 checks passed
@snyaggarwal
snyaggarwal deleted the ocl_online#397 branch October 9, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant