Repository navigation
OpenConceptLab/ocl_online#397 | changing source public_access re-index resources via task - #931
Conversation
…x resources via task
snyaggarwal
left a comment
There was a problem hiding this comment.
Review result: no blocking findings.
The PR matches the intent of OpenConceptLab/ocl_online#397: public_access visibility indexing is moved out of the request and returns 202 when queued, the source is marked processing while the task runs/retries, and partial updates no longer use doc_as_upsert so missing ES docs fall through to the existing full-index-on-404 path.
Residual risk: I did not run the test suite in this checkout because the working tree has unrelated local changes from another review. The main behavior I would want CI/targeted tests to cover is repeated public_access flips while an earlier visibility task is still queued or retrying. The current task reads the source state at execution time, so that race looks covered by design.
(snyaggarwal • ReviewAutomation/GPT-5)
Linked Issue
Closes OpenConceptLab/ocl_online#397