-
Notifications
You must be signed in to change notification settings - Fork 9
Portuguese (Brazil) Translation & Language Persistence #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
filiperochalopes
wants to merge
26
commits into
OpenConceptLab:main
Choose a base branch
from
filiperochalopes:feature/translation-pt-br-i18n
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,147
−302
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
870b4a1
feat: Add Portuguese (Brazil) translation for OCL Mapper
filiperochalopes e5d4d5d
feat(i18n): add Portuguese (Brazil) translation support
filiperochalopes b05133c
feat(i18n): support recent activity translations
filiperochalopes 8bced0b
fix(i18n): change Excluir to Desconsiderar for mapping decision exclude
filiperochalopes 8ba9f5b
fix(i18n): change matching_algorithm to Algoritmo de correspondência
filiperochalopes d2bfac4
fix(i18n): fix concurrent_requests spelling (Concurrentes → Simultâneas)
filiperochalopes c3835e6
fix(i18n): change source_code to Código de Origem
filiperochalopes a00efd4
fix(i18n): remove duplicate proposed_successfully key
filiperochalopes 84c4530
fix(i18n): change delete to exclua in preview_limit_body_projects
filiperochalopes d24e959
fix(i18n): change algorithm_es_label to use Elasticsearch product name
filiperochalopes 3358a2a
fix(i18n): fix preview_limit_notify_me grammar
filiperochalopes 4c2dbee
fix(i18n): fix algo_canonical_url_description preposition
filiperochalopes be4a6fa
fix(i18n): add missing scispacy preview limit keys
filiperochalopes de80cd9
fix(i18n): fix bulk_confirm_body assembled text
filiperochalopes 9d08aac
fix(i18n): change common.at from às to em
filiperochalopes 00fb2b6
fix(i18n): remove 'em' from last_saved
filiperochalopes 2871616
fix(i18n): fix error page assembled text fragments
filiperochalopes 62960c6
fix(i18n): fix common.for and common.please for error pages
filiperochalopes 11c9ec3
fix(i18n): fix org_have_not_created_public_repos_suffix verb agreement
filiperochalopes 23f63a1
fix(i18n): fix resolve_success_with_entry placeholder order
filiperochalopes 134fec2
fix(i18n): fix resolve_failed placeholder order
filiperochalopes 26d14c3
fix(i18n): change first_name/last_name to Nome/Sobrenome
filiperochalopes ca575ee
fix(i18n): change preview_quota_tooltip_title permissao to cota
filiperochalopes 9554b19
fix(i18n): change preview_limit_body_rows_not_entitled_no_count permi…
filiperochalopes 1ac5cab
fix(i18n): change stopping_gracefully to Encerrando com segurança
filiperochalopes 25e2f8a
fix(i18n): rewrite preview_limit_hardship_note for grant funding context
filiperochalopes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these two translation keys are not used anywhere in this project
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete analysis of unused i18n keys (228 of 752 = 30.3%)
These keys exist in src/i18n/locales/en/translations.json but are not referenced anywhere in the codebase (neither via t(), nor template strings, nor i18nKey in the Trans component).
They appear to have been copied from oclweb3 (just like I did with some recent keys).
By namespace/scope:
common (50) - single words and rarely used variants
common.a, common.an, common.for, common.from, common.with
common.action, common.about, common.access_level, common.attribute
common.clear, common.content_summary, common.create, common.created
common.created_on, common.custom_attributes, common.draft
common.group, common.highlights, common.history, common.import
common.json, common.languages, common.last_updated_on, common.less
common.manage, common.metadata, common.navigate, common.ok
common.open, common.overview, common.preferred_language, common.private
common.public, common.read_less, common.read_more, common.resolve
common.result, common.select, common.short_code, common.sort
common.statistics, common.subscribed, common.summary, common.target
common.updated_on, common.upload, common.value, common.versions
common.view_all_attributes
repo (44) - advanced repository configuration (auto-ID, metadata, comparison)
repo.add_concept, repo.autoid_concept_description_external_id
repo.autoid_concept_external_id, repo.autoid_concept_mnemonic
repo.autoid_concept_name_external_id, repo.autoid_mapping_external_id
repo.autoid_mapping_mnemonic, repo.case_sensitive, repo.collection_type
repo.compare, repo.compare_destination_version_disabled_tooltip
repo.compare_origin_version_disabled_tooltip, repo.compare_versions
repo.compositional, repo.contact, repo.content_type, repo.copyright
repo.custom_validation_schema, repo.experimental, repo.hierarchy_meaning
repo.identifier, repo.jurisdiction, repo.locale, repo.locales
repo.manage, repo.no_overview, repo.property, repo.publisher
repo.purpose, repo.refresh_summary, repo.release_status, repo.repo_id
repo.repo_summary_is_calculating, repo.repo_type, repo.repo_version_summary
repo.revision_date, repo.source_type, repo.summary_active_concepts_from_total
repo.summary_active_mappings_from_total, repo.summary_concepts_references
repo.summary_mappings_references, repo.summary_released_versions_from_total
repo.version_needed, repo.visibility
map_project (34) - premium algorithms, preview settings, limit UI
map_project.ai_assistant_limit_reached
map_project.algorithm_custom_description, map_project.algorithm_custom_label
map_project.algorithm_es_label, map_project.algorithm_llm_label
map_project.auto_match_note_no_counts, map_project.auto_matched
map_project.bridge_terminology_search, map_project.bridge_terminology_search_description
map_project.bulk_clear_selection, map_project.ciel_bridge_terminology_candidates
map_project.custom_match_api, map_project.custom_match_api_description
map_project.delete_this_project, map_project.enable_reranker
map_project.include_retired, map_project.lookup_required, map_project.map_target
map_project.match_api_token, map_project.match_api_token_placeholder
map_project.match_api_url, map_project.match_api_url_placeholder
map_project.ocl_ciel_bridge_algorithm, map_project.ocl_custom_algorithm
map_project.ocl_scispacy_loinc_algorithm
map_project.preview_quota_ai_calls, map_project.preview_quota_match_operations
map_project.preview_quota_projects, map_project.rows_per_match_api
map_project.save_this_project_to_collection, map_project.scispacy_loinc_search
map_project.select_an_algorithm, map_project.show_more
map_project.target_repo_required_on_load
user (33) - profile, avatar, bio, account settings
user.about_me, user.about_me_description, user.avatar, user.bio
user.company, user.company_name, user.copy_api_token, user.copy_token_success
user.edit_my_profile, user.email, user.email_address, user.first_name
user.joined_on, user.last_login, user.last_name, user.location
user.login_and_security, user.my_bookmarks, user.my_organizations
user.name_and_description, user.own_recent_activity, user.password
user.profile_update_failure, user.profile_update_success
user.recent_activity, user.recent_activity_of, user.update_avatar
user.user, user.user_has_not_created_public_repos_suffix, user.username
user.users, user.website, user.your
url_registry (14) - canonical URL registry
search (12) - display variants (card/table, placeholders)
mapping (11) - mapping types and sources
dashboard (8) - homepage/dashboard
org (6) - organizations
concept (8) - classes, namespaces, bridge tabs
auth (4) - auth flows (verified email, expired session)
bookmarks (3) - bookmarks functionality
custom_attributes (1)
Important notes
Suggestion
Removing these 228 keys from translations.json (and corresponding PT-BR files) would reduce the translation bundle by ~30% and avoid unnecessary translation work. Many appear to be legacy from oclweb3 that were never integrated into the mapper.
Regarding the keys at lines 341-343 (user.recent_activity, user.own_recent_activity, user.recent_activity_of): confirmed as unused - the code uses user.recent_activity only as a static label in some places, but these 3 specific keys are not called via t().
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, but pending the others OpenConceptLab/ocl_issues#2880