Get rid of fixed variable names for iptable rules#515
Open
baszoetekouw wants to merge 2 commits into
Open
Conversation
baszoetekouw
force-pushed
the
feature/dynamic_iptables
branch
from
April 2, 2026 14:56
669e142 to
d59b193
Compare
baszoetekouw
changed the title
baszoetekouw
marked this pull request as ready for review
July 22, 2026 19:50
Member
Author
|
@crosmuller @pmeulen zoiets als dit lijkt me nog steeds een verbetering, al wordt het wel een beetje magie op deze manier. Wat denken jullie? |
crosmuller
reviewed
Jul 23, 2026
crosmuller
left a comment
crosmuller
left a comment
Contributor
There was a problem hiding this comment.
Lijkt me goed, ik durf hem niet meteen te approven want ik weet niet in hoeverre het getest is. De magic kan ik mee leven :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untested, later nog een keer kijken hoe we dit mooi kunnen maken