Repository navigation
task-based execution: add option to increase max_tries - #2227
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2227 +/- ##
==========================================
- Coverage 95.13% 90.42% -4.71%
==========================================
Files 224 226 +2
Lines 22009 22198 +189
==========================================
- Hits 20938 20073 -865
- Misses 1071 2125 +1054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
IAlibay
self-requested a review
October 5, 2026 14:06
atravitz
force-pushed
the
feat/add_max_tries_update
branch
5 times, most recently
from
October 5, 2026 22:29
dd9b1c6 to
82be8e1
Compare
atravitz
marked this pull request as ready for review
October 5, 2026 22:35
IAlibay
reviewed
Oct 6, 2026
IAlibay
left a comment
Member
There was a problem hiding this comment.
Overall looks good - maybe a quick line or two in the userguide on how to use this would be useful.
atravitz
force-pushed
the
feat/add_max_tries_update
branch
2 times, most recently
from
October 6, 2026 18:39
59387f7 to
146242b
Compare
Contributor
Author
will add here once this PR gets merged: OpenFreeEnergy/ExampleNotebooks#322 |
IAlibay
requested changes
Oct 7, 2026
IAlibay
left a comment
Member
There was a problem hiding this comment.
Couple things, please feel free to ignore the nits.
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
atravitz
force-pushed
the
feat/add_max_tries_update
branch
from
October 7, 2026 14:50
97d75fc to
9620cbb
Compare
IAlibay
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #2214
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin