Repository navigation
Bump wfb-ng submodule to upstream master (3504a38) - #122
Conversation
Previous pin (0da5279, 2025-08-05) was about a year and 56 commits behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4 constructor signature and the public counters WfbngLink.cpp reads (count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost, count_p_bad, count_p_override, count_p_outgoing) are unchanged between the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional PacketLossListener with no-op-by-default virtuals), not a breaking API change. Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no regressions in video/MAVLink reception. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can move or hide resolved findings to focus on what still needs action |
PR Summary by QodoBump wfb-ng submodule to upstream commit 3504a38
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
Code review by qodo was updated up to the latest commit e14647b |
josephnef
left a comment
There was a problem hiding this comment.
Approving. The new PR checks ran on this branch after reopening: the wfbngrtl8812 CMake source list (zfex, radiotap, rx, wifibroadcast) still resolves at 3504a38 and the debug APK builds, which confirms the API-compatibility reasoning in the description. On-device test on RTL8812AU noted.
One housekeeping note: Dependabot now watches the gitsubmodule ecosystem weekly, so future wfb-ng/devourer bumps will arrive as automatic PRs. Merging this one as-is is still the right call since it carries the compatibility analysis.
Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.
Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.
🤖 Generated with Claude Code