Skip to content

Bump wfb-ng submodule to upstream master (3504a38) - #122

Merged
josephnef merged 1 commit into
OpenIPC:masterfrom
mengelh:wfb-ng-submodule-bump
Oct 18, 2026
Merged

josephnef merged 1 commit into
OpenIPC:masterfrom
mengelh:wfb-ng-submodule-bump

Conversation

@mengelh

@mengelh mengelh commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.

Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.

🤖 Generated with Claude Code

Previous pin (0da5279, 2025-08-05) was about a year and 56 commits
behind svpcom/wfb-ng master. Verified the Aggregator/AggregatorUDPv4
constructor signature and the public counters WfbngLink.cpp reads
(count_p_all, count_p_dec_err, count_p_fec_recovered, count_p_lost,
count_p_bad, count_p_override, count_p_outgoing) are unchanged between
the two commits -- the diff in rx.cpp/rx.hpp is internal (packet dedup
via a new SeenPacketsSet, RSSI/SNR linear-scale averaging, an optional
PacketLossListener with no-op-by-default virtuals), not a breaking API
change.

Built and ran on-device (RTL8812AU, Galaxy Tab S7 FE) with no
regressions in video/MAVLink reception.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can move or hide resolved findings to focus on what still needs action

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Previous reviews

Review updated until commit e14647b ⚖️ Balanced

Results up to commit e14647b


🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Sep 9, 2026 •

Copy link
Copy Markdown

PR Summary by Qodo

Bump wfb-ng submodule to upstream commit 3504a38

⚙️ Configuration changes 🕐 20-40 Minutes

Grey Divider

AI Description

• Advance the wfb-ng submodule pin to upstream commit 3504a38, bringing in newer receiver behavior.
• Preserve the existing aggregator integration; on-device video and MAVLink reception showed no
 regressions.
Diagram

graph TD
  A["USB radio"] --> B["WfbngLink"] --> C["wfb-ng aggregators"] --> D["UDP consumers"]
Loading
High-Level Assessment

Keep the upstream submodule pin: the existing build and aggregator integration require no changes, and the reported on-device test covers the primary reception paths. Vendoring or rewriting the receiver would add maintenance burden without a clear benefit.

Files changed (1) +1 / -1

Other (1) +1 / -1
wfb-ngAdvance the wfb-ng submodule pin +1/-1

Advance the wfb-ng submodule pin

• Changes the pinned upstream commit from 0da5279 to 3504a38. No application source or build configuration changes accompany the dependency update.

app/wfbngrtl8812/src/main/cpp/wfb-ng

@josephnef josephnef closed this Oct 18, 2026
@josephnef josephnef reopened this Oct 18, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit e14647b

@josephnef josephnef left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The new PR checks ran on this branch after reopening: the wfbngrtl8812 CMake source list (zfex, radiotap, rx, wifibroadcast) still resolves at 3504a38 and the debug APK builds, which confirms the API-compatibility reasoning in the description. On-device test on RTL8812AU noted.

One housekeeping note: Dependabot now watches the gitsubmodule ecosystem weekly, so future wfb-ng/devourer bumps will arrive as automatic PRs. Merging this one as-is is still the right call since it carries the compatibility analysis.

@josephnef
josephnef merged commit a68a61f into OpenIPC:master Oct 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants