Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is no Buildroot target to build and install the NT98513 stock-ABI diagnostic tools proposed in OpenIPC/ipctool#246. Add a separate, default-off
nt98513-diagnosticspackage fornt98513-descriptor-probe,nt98513-clientandnt98513-sensor; leave the existingipctoolpackage unchanged.Dependency: ipctool PR 246 is unmerged. This draft pins its tested head,
c6fba9743e6b3924a3652d72fbcbdf564cbd33bb, from the OpenIPC repository. Land that source change first and confirm the pin before merging this package. Diagnostic implementation stays in ipctool; this diff contains only packaging and CI selection metadata.Hardware tested on
None. Keep this PR as a draft: no camera, complete firmware image, boot, live IPC transaction or capture was tested. The evidence below covers a real package build/install and userspace emulation of the installed tools.
Evidence
Before, the package target did not exist:
After
make -C /br O=/work/on BR2_EXTERNAL=/firmware/general -j4 nt98513-diagnostics:CMAKE_SYSTEM_NAME=Linuxis package-local. All 20 production source files match the pinned ipctool commit.The package build used firmware base
86ccd6fa1d016cacda6dfbcddc1b90fe685cba1e. On current base751b2f4fb99b438fd8ec6e54c7defc662a942984, the unchanged package files and updated selector were checked separately:The latter uses the exact five changed paths with both base-selector and package-index diff inputs. Omitting either widens to 99 boards; a draft event selects none. These are selector results, not completed board builds.
Validation limitation: eight pairs of case-distinct Linux UAPI headers collided during SDK extraction on the host filesystem. The original archive is intact; the compiler/helper binaries and all three SDK headers consumed by these diagnostics match the archive. This validates this package's consumed inputs, not the complete extracted SDK. Future SDK reuse requires fresh case-sensitive extraction.
Scope
general/package/all-patches/linux/.load_<vendor>changes, services or device nodes.LD_PRELOADor checked-in binaries; Buildroot builds the tools from source.The unchecked item is deliberate: these are manual diagnostics for a recovered stock Linux ABI, and no supported NT98513 board configuration is available. The package stays default-off with MIPSEL/MIPS32r2/O32 gates and a reasoned
NOT_BUILTentry. No existing board is enabled, and this does not add NT98513 board support.