Skip to content

gk7202v300, gk7605v100: build the split NOR package too - #2621

Merged
widgetii merged 1 commit into
masterfrom
nor/fit-split-gk7202v300-gk7605v100
Oct 17, 2026
Merged

widgetii merged 1 commit into
masterfrom
nor/fit-split-gk7202v300-gk7605v100

Conversation

@widgetii

Copy link
Copy Markdown
Member

This finishes the split NOR layout (#2617) for the other two SoCs in the gk7205v200 kernel family.

Their kernels already have mtdsplit and the split options from the shared config fragments. But only the gk7205v200/v300 defconfigs ran post-image.sh, so these boards built no firmware.bin and no openipc.<soc>-nor-<variant>-split.tgz. That correction applies to #2617's description too, which said they did. This adds the post-image script to gk7202v300_lite, gk7202v300_ultimate and gk7605v100_lite. The plain package is unchanged.

The bootloader side is OpenIPC/u-boot#19, which is merged. Until a camera runs a bootloader with it (publish follows this PR), sysupgrade keeps it on the plain package.

Local builds

gk7202v300_lite:  uImage [1857KB/2048KB]  rootfs.squashfs [5064KB/5120KB]  firmware.bin [7040KB/7616KB]
gk7605v100_lite:  uImage [1857KB/2048KB]  rootfs.squashfs [5080KB/5120KB]  firmware.bin [7040KB/7616KB]

Each build produces both packages, and each FIT is described OpenIPC gk7202v300 / OpenIPC gk7605v100, which is what sysupgrade checks against the camera.

Build-tested only: I have no gk7202v300 or gk7605v100 camera. The same kernel, U-Boot code and sysupgrade paths are verified on GK7205V200 and GK7205V300 (#2617).

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Build split NOR packages for GK7202V300 and GK7605V100

⚙️ Configuration changes ✨ Enhancement 🕐 10-20 Minutes

Grey Divider

AI Description

• Enable the shared post-image script for three GK7202V300 and GK7605V100 builds.
• Produce split NOR firmware packages alongside the unchanged plain packages.
• Local builds succeeded; camera upgrades remain untested and require a compatible bootloader.
Diagram

graph TD
  A["Three defconfigs"] --> B["Post-image script"] --> C["FIT image"] --> D["Firmware image"] --> E["Package rules"] --> F["Split package"]
  G["Squashfs rootfs"] --> D
Loading
High-Level Assessment

Reuse the existing family post-image script and packaging rules. The missing per-variant Buildroot setting is the only change needed; duplicating image-generation logic would add maintenance cost without changing the output.

Files changed (3) +3 / -0

Other (3) +3 / -0
gk7202v300_lite_defconfigEnable split NOR image generation for GK7202V300 lite +1/-0

Enable split NOR image generation for GK7202V300 lite

• Configures the GK7205V200-family post-image script for this variant. Its output can now be packaged as split NOR firmware alongside the existing plain package.

br-ext-chip-goke/configs/gk7202v300_lite_defconfig

gk7202v300_ultimate_defconfigEnable split NOR image generation for GK7202V300 ultimate +1/-0

Enable split NOR image generation for GK7202V300 ultimate

• Configures the same family post-image script for the ultimate variant, enabling its split NOR firmware artifact without changing the plain package.

br-ext-chip-goke/configs/gk7202v300_ultimate_defconfig

gk7605v100_lite_defconfigEnable split NOR image generation for GK7605V100 lite +1/-0

Enable split NOR image generation for GK7605V100 lite

• Configures the shared post-image script for GK7605V100 lite so the existing packaging rules can produce its split NOR archive alongside the plain package.

br-ext-chip-goke/configs/gk7605v100_lite_defconfig

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (1) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Action required

1. Cameras get unverified images 📘 Rule violation ☼ Reliability
Description
BR2_ROOTFS_POST_IMAGE_SCRIPT is newly enabled in three board defconfigs without camera-level
validation of the resulting firmware and split package. The PR explicitly reports build-only testing
with no gk7202v300 or gk7605v100 camera, so boot and runtime behavior for every newly enabled board
path remains unverified.
Code

br-ext-chip-goke/configs/gk7202v300_lite_defconfig[24]

+BR2_ROOTFS_POST_IMAGE_SCRIPT="$(EXTERNAL_VENDOR)/board/$(OPENIPC_SOC_FAMILY)/post-image.sh"
Evidence
The three changed defconfigs enable a post-image script and therefore change the firmware artifacts
produced for affected boards. The PR description states that testing was build-only and that no
gk7202v300 or gk7605v100 camera was available, which fails the hardware-evidence requirement for a
firmware-affecting change.

Rule 3: Hardware evidence is present and honest
br-ext-chip-goke/configs/gk7202v300_lite_defconfig[24-24]
br-ext-chip-goke/configs/gk7202v300_ultimate_defconfig[24-24]
br-ext-chip-goke/configs/gk7605v100_lite_defconfig[24-24]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The new post-image configuration changes the firmware artifacts produced for gk7202v300 and gk7605v100 boards, but the PR provides only build output and explicitly reports that no affected camera was tested.
## Fix Focus Areas
- br-ext-chip-goke/configs/gk7202v300_lite_defconfig[24-24]
- br-ext-chip-goke/configs/gk7202v300_ultimate_defconfig[24-24]
- br-ext-chip-goke/configs/gk7605v100_lite_defconfig[24-24]
## Recommended Fix
Test the resulting firmware and split package on real gk7202v300 and gk7605v100 cameras, then add before/after evidence covering the affected board, boot behavior, and streaming behavior. If hardware is unavailable, do not claim hardware validation; provide the self-test, selector output, or parse/build evidence that the change class can support.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can see how risky a PR is at a glance with blast radius labels

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread br-ext-chip-goke/configs/gk7202v300_lite_defconfig
Their kernels already carry mtdsplit and the split options (the
gk7205v200 family's config fragments, #2617), but only the gk7205v200
and gk7205v300 defconfigs ran post-image.sh, so these two produced no
firmware.bin and no -split package. They now do, beside the unchanged
plain package. OpenIPC/u-boot#19 enables the layout in their
bootloaders; until a camera runs one, sysupgrade keeps it on the plain
package.

Local builds: gk7202v300_lite firmware.bin 7040KB/7616KB, gk7605v100_lite
7040KB/7616KB; each FIT is described "OpenIPC <soc>".

Build-tested only: no gk7202v300 or gk7605v100 camera was run.
@widgetii
widgetii force-pushed the nor/fit-split-gk7202v300-gk7605v100 branch from d21eba4 to dabbacb Compare October 17, 2026 17:31
@widgetii
widgetii merged commit e8d577a into master Oct 17, 2026
32 of 33 checks passed
@widgetii
widgetii deleted the nor/fit-split-gk7202v300-gk7605v100 branch October 17, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant