Repository navigation
ci: build and smoke-test the XM530/XM550 SPI NAND images - #17
Merged
Merged
Conversation
xm530 and xm550 now build "nor nand", with the NAND image held to the 768 KiB boot partition, and qemu_smoke gets a NAND leg for each: the image laid into a raw 128 MiB SPI NAND (2048+64-byte pages) and booted twice through qemu-hisilicon's NAND model, passing on the autoboot prompt and failing if the second boot cannot load the environment the first saved in NAND. The NAND images follow a guess at how the XM530 boots from SPI NAND -- nothing documents it -- and the qemu model implements the same guess, so the README marks them unverified on silicon. Checked locally: all five smoke legs pass as written, against qemu-hisilicon with the NAND model.
PR Summary by QodoBuild and smoke-test XM530/XM550 SPI NAND images
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can see how risky a PR is at a glance with blast radius labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openipc-xmnow builds SPI NAND images for xm530/xm550 (#16). This PR:kinds: "nor nand", checking each NAND image against the 768 KiB boot partition;qemu_smokeleg for each. The leg lays the image into a raw 128 MiB SPI NAND (2048+64-byte pages) and boots it twice through qemu-hisilicon's NAND model (binman: Fix replacing FIT subentries u-boot/u-boot#152). It passes on the autoboot prompt and fails if the second boot can't load the env the first boot saved in NAND;Checked locally: all five smoke legs (3 NOR, 2 NAND) pass as written against qemu-hisilicon master. This PR's own run builds the current
openipc-xm.