Skip to content

fix(firewall): handle localized rule status#203

Merged
Suyunmeng merged 2 commits into
mainfrom
issue-182-fix-port-forward-state
Jul 23, 2026
Merged

fix(firewall): handle localized rule status#203
Suyunmeng merged 2 commits into
mainfrom
issue-182-fix-port-forward-state

Conversation

@Suyunmeng

@Suyunmeng Suyunmeng commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary / 摘要

  • Fix firewall status detection on localized Windows systems so the dashboard continues to show the actual rule state after navigating away and back.
    修复本地化 Windows 系统上的防火墙状态检测,使用户切换页面再返回后,主页仍显示规则的真实状态。

  • Replace localized netsh text parsing with structured Windows Firewall COM properties for the rule name, enabled state, direction, action, protocol, and local port.
    使用结构化的 Windows 防火墙 COM 属性替代本地化的 netsh 文本解析,精确检查规则名称、启用状态、方向、动作、协议和本地端口。

  • Distinguish matching rules, non-matching rules, and query failures so a query error cannot trigger a firewall write operation.
    区分规则匹配、规则不匹配和查询失败,防止查询错误触发防火墙写操作。

  • Make repeated allow operations idempotent and honor backend operation failures in the UI.
    使重复放行操作具备幂等性,并让界面正确处理后端操作失败。

  • Disable the firewall button while its initial state is being queried to avoid a mount-time race.
    在初始状态查询期间禁用防火墙按钮,避免组件挂载时的竞态操作。

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。

  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。

  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Related repository PRs / 关联仓库 PR:

  • OpenList-Frontend: N/A
  • OpenList-Docs: N/A

Related Issues / 关联 Issue

Fixes #182

Testing / 测试

  • go test ./... (not applicable to this Tauri/Vue repository / 不适用于此 Tauri/Vue 仓库)
  • vue-tsc --noEmit
  • ESLint on the changed Vue component after excluding the checkout's existing CRLF/Prettier baseline mismatch.
    / 排除当前检出中既有的 CRLF/Prettier 基线差异后,对修改的 Vue 组件执行了 ESLint。
  • Prettier check on the changed Vue component while preserving the checkout's CRLF line endings.
    / 在保留当前检出 CRLF 换行符的情况下,对修改的 Vue 组件执行了 Prettier 检查。
  • Manual test / 手动测试:
    • Verified the Windows Firewall COM query returns distinct exit codes for a matching rule, a non-matching rule, and a query failure.
      验证 Windows 防火墙 COM 查询对规则匹配、规则不匹配和查询失败分别返回不同退出码。
    • Verified the query against the existing local OpenList Core rule without modifying firewall state.
      对本机现有的 OpenList Core 规则进行了只读查询验证,未修改防火墙状态。
    • Verified git diff --check and reviewed all firewall call sites.
      验证了 git diff --check,并复查了全部防火墙调用点。

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

@Suyunmeng
Suyunmeng merged commit 5674539 into main Jul 23, 2026
11 checks passed
@Suyunmeng
Suyunmeng deleted the issue-182-fix-port-forward-state branch July 23, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[错误] 端口放行按钮

1 participant