Skip to content

fix(115_open): clean parent path before lookup#2820

Merged
jyxjjj merged 1 commit into
OpenListTeam:mainfrom
syscc:fix/115-open-parent-path
Jul 22, 2026
Merged

fix(115_open): clean parent path before lookup#2820
jyxjjj merged 1 commit into
OpenListTeam:mainfrom
syscc:fix/115-open-parent-path

Conversation

@syscc

@syscc syscc commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary / 摘要

  • Normalize the parent path returned by path.Split before requesting 115 folder metadata.

  • Restore nested directory creation in the 115 Open driver by avoiding a trailing slash that the 115 API interprets as an empty directory name.

  • No public API, configuration, storage format, or dependency changes.

  • This PR has breaking changes.
    / 此 PR 包含破坏性变更。

  • This PR changes public API, config, storage format, or migration behavior.
    / 此 PR 修改了公开 API、配置、存储格式或迁移行为。

  • This PR requires corresponding changes in related repositories.
    / 此 PR 需要关联仓库同步修改。

Testing / 测试

  • go test ./...
  • Manual test / 手动测试:
    • macOS arm64, Go 1.26.5.
    • Ran from source with go run main.go --data <test-data> server --debug --log-std.
    • Reproduced the failure against beta commit d90ef1e, then verified the fix against current upstream main (bacd0870) plus this commit.
    • Used the same 115 Open storage for the before/after requests. The temporary directories were removed after verification.

Failure log before the fix

Creating a directory directly below the mount root succeeded:

POST /api/fs/mkdir
Content-Type: application/json

{"path":"/115/__openlist_mkdir_probe_20260722"}

HTTP/1.1 200
{"code":200,"message":"success","data":null}

Creating its child failed before Mkdir was reached:

POST /api/fs/mkdir
Content-Type: application/json

{"path":"/115/__openlist_mkdir_probe_20260722/child_ascii"}

HTTP/1.1 500
{"code":500,"message":"failed to check if dir exists: failed to get obj: code: 20001, message: 目录名称不能为空。","data":null}

The first lookup of the missing child returned an empty data array as expected. The fallback then sent the parent path with the trailing slash produced by path.Split:

POST https://proapi.115.com/open/folder/get_info
Content-Type: application/x-www-form-urlencoded

path=/__openlist_mkdir_probe_20260722/

HTTP/1.1 200
{"state":false,"message":"目录名称不能为空。","code":20001,"data":[]}

Sending the same parent path without the trailing slash returned the folder metadata successfully. Sensitive file IDs and pick codes are omitted:

POST https://proapi.115.com/open/folder/get_info
Content-Type: application/x-www-form-urlencoded

path=/__openlist_mkdir_probe_20260722

HTTP/1.1 200
{"state":true,"message":"","code":0,"data":{"file_name":"__openlist_mkdir_probe_20260722","file_category":"0","...":"redacted"}}

Verification log after the fix

Both root and nested directory creation succeeded:

POST /api/fs/mkdir
{"path":"/115/__openlist_mkdir_fix_verify_20260722"}

{"code":200,"message":"success","data":null}

POST /api/fs/mkdir
{"path":"/115/__openlist_mkdir_fix_verify_20260722/二级目录测试"}

{"code":200,"message":"success","data":null}

Listing the parent confirmed that the child was created:

{"code":200,"message":"success","data":{"content":[{"name":"二级目录测试","is_dir":true}],"total":1,"...":"omitted"}}

Cleanup succeeded, and the follow-up lookup confirmed removal:

{"code":200,"message":"success","data":null}
{"code":500,"message":"failed to get obj: object not found","data":null}

Additional checks:

  • gofmt -d drivers/115_open/driver.go produced no output.
  • git diff --check passed.
  • The full test suite was not run locally; repository CI is expected to perform the broader build checks.

Checklist / 检查清单

  • I have read CONTRIBUTING.
    / 我已阅读 CONTRIBUTING
  • I confirm this contribution follows the repository license, contribution policy, and code of conduct.
    / 我确认此贡献符合仓库许可证、贡献规范和行为准则。
  • I have formatted the changed code with gofmt, go fmt, or prettier where applicable.
    / 我已按适用情况使用 gofmtgo fmtprettier 格式化变更代码。
  • I have requested review from relevant maintainers or code owners where applicable.
    / 我已在适用情况下请求相关维护者或代码所有者审查。

AI Disclosure / AI 使用声明

  • This PR includes AI-assisted content.
    / 此 PR 包含 AI 辅助内容。

Tools used / 使用工具:

  • ChatGPT
  • Codex
  • GitHub Copilot
  • Claude
  • Gemini
  • Other (please specify) / 其他(请注明):

Usage scope / 使用范围:

  • Code generation / 代码生成

  • Refactoring / 重构

  • Documentation / 文档

  • Tests / 测试

  • Translation / 翻译

  • Review assistance / 审查辅助

  • I have reviewed and validated all AI-assisted content included in this PR.
    / 我已审核并验证此 PR 中的所有 AI 辅助内容。

  • I have ensured that all AI-assisted commits include Co-Authored-By attribution.
    / 我已确保所有 AI 辅助提交都包含 Co-Authored-By 归属信息。

  • I can reproduce all AI-assisted content included in this PR without any AI tools.
    / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。

- Normalize parent paths before requesting folder metadata.
- Prevent nested directory checks from sending trailing slashes to 115.

Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
@jyxjjj
jyxjjj merged commit a21bc8b into OpenListTeam:main Jul 22, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants