fix(115_open): clean parent path before lookup#2820
Merged
Conversation
- Normalize parent paths before requesting folder metadata. - Prevent nested directory checks from sending trailing slashes to 115. Co-authored-by: Codex <267193182+codex@users.noreply.github.com>
jyxjjj
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
Normalize the parent path returned by
path.Splitbefore requesting 115 folder metadata.Restore nested directory creation in the 115 Open driver by avoiding a trailing slash that the 115 API interprets as an empty directory name.
No public API, configuration, storage format, or dependency changes.
This PR has breaking changes.
/ 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior.
/ 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories.
/ 此 PR 需要关联仓库同步修改。
Testing / 测试
go test ./...go run main.go --data <test-data> server --debug --log-std.d90ef1e, then verified the fix against current upstreammain(bacd0870) plus this commit.Failure log before the fix
Creating a directory directly below the mount root succeeded:
Creating its child failed before
Mkdirwas reached:The first lookup of the missing child returned an empty data array as expected. The fallback then sent the parent path with the trailing slash produced by
path.Split:Sending the same parent path without the trailing slash returned the folder metadata successfully. Sensitive file IDs and pick codes are omitted:
Verification log after the fix
Both root and nested directory creation succeeded:
Listing the parent confirmed that the child was created:
{"code":200,"message":"success","data":{"content":[{"name":"二级目录测试","is_dir":true}],"total":1,"...":"omitted"}}Cleanup succeeded, and the follow-up lookup confirmed removal:
{"code":200,"message":"success","data":null} {"code":500,"message":"failed to get obj: object not found","data":null}Additional checks:
gofmt -d drivers/115_open/driver.goproduced no output.git diff --checkpassed.Checklist / 检查清单
/ 我已阅读 CONTRIBUTING。
/ 我确认此贡献符合仓库许可证、贡献规范和行为准则。
gofmt,go fmt, orprettierwhere applicable./ 我已按适用情况使用
gofmt、go fmt或prettier格式化变更代码。/ 我已在适用情况下请求相关维护者或代码所有者审查。
AI Disclosure / AI 使用声明
/ 此 PR 包含 AI 辅助内容。
Tools used / 使用工具:
Usage scope / 使用范围:
Code generation / 代码生成
Refactoring / 重构
Documentation / 文档
Tests / 测试
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR.
/ 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution./ 我已确保所有 AI 辅助提交都包含
Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools.
/ 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。