Repository navigation
PSM tables: show modifications as labels, ProForma or OpenMS; ProForma in exports - #48
Open
t0mdavid-m wants to merge 1 commit into
Open
t0mdavid-m wants to merge 1 commit into
t0mdavid-m wants to merge 1 commit into
Conversation
… ProForma in exports Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D5Wo2FHPpi5a8X6GppNxEk
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the PSM tables on Database Search, Rescoring and Filtered PSMs show the raw OpenMS string, e.g.
.(Acetyl)M(Oxidation)DNFES(Phospho)TAEGNLSIGNK. The PSM downloads carry only that string as well.After: a Modifications switch above each PSM table offers three views.
ac-M(ox)DNFES(ph)TAEGNLSIGNK.[Acetyl]-M[Oxidation]DNFES[Phospho]TAEGNLSIGNK.The choice carries across the three pages and survives navigating away. Row selection still drives the spectrum and sequence views. The PSM and fragment-ion TSV exports gain a
proformacolumn next to the OpenMSsequence.This is ProSE parity item R10 (modification display switch).
How:
src/common/peptide_format.pybuilds both forms with pyOpenMSAASequence, so any modification OpenMS knows works.X-and-X.src/common/sequence_display.pyhandles the non-OpenMS views.Tablecache with the formatted Sequence column. The links, row ids, sort and columns are copied from the original's manifest.Validation:
tests/test_peptide_format.pyhas 8 tests: terminal mods, short labels, mass-only mods and pass-through.tests/test_sequence_display.pyhas 2 tests: the variant cache's data and manifest, and its rebuild after a new run.test_result_exportsnow checks theproformacolumn.pytest tests/passed 123 tests.pylint --errors-onlyreports only the usual E0611 false positives onpyopenmsimports (compiled module).Generated by Claude Code