Repository navigation
refactor: simplify PeerManager.add_peer - #9582
Merged
Merged
Conversation
- Split the early return and the verbose prints into helpers. - Build a fresh Peer instead of changing the cached one; PeerStore.set_peer now carries over info, state_at_start and the bundle like set_peers. - Always read the peer's encryption bundle (None until published). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add_peerinto_return_early,_print_add_peer_startand_print_add_peer_done.is_accepting;add_peernow builds a freshPeerand no longer changes the cached one.PeerStore.set_peerandset_peersshare_keep_known, which carries overinfo,state_at_startand the encryption bundle.add_peeralways reads the peer's encryption bundle (returns None until the peer publishes one). Costs one extra Drive read when sending a request.Notes
Peerreference no longer sees the update afteradd_peer.set_peersnow keeps an old bundle when a reload brings none.🤖 Generated with Claude Code