Skip to content

fix(syft-job): code_hash mismatch on CRLF checkout and Windows sort o… - #9584

Open
nethantd wants to merge 1 commit into
OpenMined:devfrom
nethantd:fix/syft-job-code-hash-crlf-windows
Open

nethantd wants to merge 1 commit into
OpenMined:devfrom
nethantd:fix/syft-job-code-hash-crlf-windows

Conversation

@nethantd

Copy link
Copy Markdown

…rder

  • Pass as_sent=True in _has_all_files so both submitter and owner normalize line endings identically (text-mode read), fixing the CRLF checkout where declared code_hash never matched.
  • Sort _digest file list by relative.as_posix() instead of native Path objects, making feed order platform-independent (WindowsPath sorts case-insensitively, PosixPath case-sensitively).

Summary

Changes

Testing

Asana task


PR naming convention

Your PR title must follow this format or merging will be blocked:

type: short description in lowercase

Example titles:

  • feat: add retry logic to job approval
  • fix: handle timeout in notification sender
  • docs: update syft-bg README
  • chore: bump dependencies
  • refactor: split init flow into helpers
  • test: add criteria validation tests
  • ci: add release train workflow

Allowed types:

Type When to use Example
feat New feature or capability feat: add DS rejection emails
fix Bug fix fix: handle empty peer list
docs Documentation only docs: update syft-bg README
chore Maintenance, deps, config chore: bump dependencies
refactor Code restructuring (no behavior change) refactor: split init flow
test Adding or updating tests test: add approval criteria tests
ci CI/CD workflow changes ci: add release train workflow
perf Performance improvement perf: cache Drive API responses
build Build system or dependency changes build: pin syft-bg>=0.2.0

Just edit the PR title to fix any errors — the check re-runs automatically.

Auto-labeling

Labels are applied automatically — you don't need to add them manually:

  • Type labels from your PR title (e.g., feat: adds feature, fix: adds bugfix)
  • Package labels from which files you changed (e.g., editing packages/syft-bg/ adds pkg:syft-bg)

These labels are used to auto-generate categorized release notes.

…rder

- Pass as_sent=True in _has_all_files so both submitter and owner
  normalize line endings identically (text-mode read), fixing the
  CRLF checkout where declared code_hash never matched.
- Sort _digest file list by relative.as_posix() instead of native
  Path objects, making feed order platform-independent (WindowsPath
  sorts case-insensitively, PosixPath case-sensitively).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant