Skip to content

[com4]: Add com4 benchmark tests - #1321

Open
PaulaSp3 wants to merge 2 commits into
masterfrom
PS_benchmark
Open

[com4]: Add com4 benchmark tests#1321
PaulaSp3 wants to merge 2 commits into
masterfrom
PS_benchmark

Conversation

@PaulaSp3

@PaulaSp3 PaulaSp3 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Added benchmark data:

Added a script that run a simulation and compares the results (pixel wise) with reference data.
Comparison results are written into: avaframe/tests/reportsCom4FlowPy/standardTestsReportCom4FlowPy.md
There are many options to extent these comparisons and what we could write into the report (e.g., plot with the difference of the rasters,..)

resolves #1227

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@PaulaSp3
PaulaSp3 requested a review from ahuber-bfw July 22, 2026 14:13
@PaulaSp3 PaulaSp3 self-assigned this Jul 22, 2026
@PaulaSp3 PaulaSp3 added the flowPyDev Ideas for future development label Jul 22, 2026
@qltysh

qltysh Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: B Coverage rating: B
avaframe/ana1Tests/testUtilities.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

substituted .asc and .prj with .tif for avaArzlerAlm/Inputs/

add benchmark data with forest

minor modes to standardTestsCom4, moved data to benchmarks

moved benchmarks to ../benchmarks

added new Benchmark (com4, infra, null) modified existing com4 benchmark .jsons

added requird inputs and modified runStandardTests com4

minor mods to runStandardTests, tempdir

added avaArzlerAlmForestInfra benchmark changed data and settings for NULL benchmark

modified .ini for benchmark

cleaned up desDict.jsons and minor mods to runStandardTestsCom4.py

@ahuber-bfw ahuber-bfw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulaSp3 : gern nochmal drüber schauen, hab noch ein paar sachen am runScript und den Benchmark Daten angepasst / aufgeräumt.
@awirb, @fso42: im ana1Tests/testUtilities.py hab ich 2 Zeilen ergänzt, damit auch benchmark test folder mit 'com4*' prefix gefunden werden.

@ahuber-bfw

Copy link
Copy Markdown
Contributor

@PaulaSp3: Doku hab ich jetzt noch nicht angepasst, und ein miniTest für die compareRaster Funktion wär noch cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flowPyDev Ideas for future development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[com4]: benchmark tests

2 participants