Skip to content

make no asset value a parameter to be set - #1324

Open
awirb wants to merge 3 commits into
masterfrom
moveToIni
Open

make no asset value a parameter to be set#1324
awirb wants to merge 3 commits into
masterfrom
moveToIni

Conversation

@awirb

@awirb awirb commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

Please confirm before requesting review:

  • I ran pytest locally without fails
  • I added/updated tests where needed
  • I updated documentation where needed

Confirm before the final merge/rebase into master

  • Commits are sensibly squashed and rebased onto latest master
  • Standardtest run without difference (with recompiled cython code)

@awirb
awirb requested review from ahuber-bfw and fso42 August 5, 2026 08:37
@awirb awirb self-assigned this Aug 5, 2026
@awirb awirb added the featureRequest ideas or functions that would be useful label Aug 5, 2026
@qltysh

qltysh Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Qlty


Coverage Impact

This PR will not change total coverage.

Modified Components (1)

RatingComponent% Diff
Coverage rating: C Coverage rating: C
com1DFA100.0%

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: D Coverage rating: D
avaframe/com1DFA/particleTools.py100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@ahuber-bfw ahuber-bfw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funktioniert bei mir

  • hab noch das runScript minimal angepasst, damit man auswählen kann ob '.tif' oder '.asc' als output.
  • sonst Doku noch anpassen?

@@ -1024,6 +1026,8 @@ def createAssetsRasterFromParticleLocations(particlesTimeArrays, dem, uniqueAsse
list of assets class values sorted from low to high
assetsValues: dict
dictionary with for each infrastructure class value the affected cell numbers

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dictionary with for each infrastructure class value the affected cell numbers
dictionary with affected cell numbers for each asset class


def createAssetsRasterFromParticleLocations(particlesTimeArrays, dem, uniqueAssets, assetsValues):
def createAssetsRasterFromParticleLocations(
particlesTimeArrays, dem, uniqueAssets, assetsValues, noAssetsClass

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime error if noAssetClass is not provided in function call --> ok or use default value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

featureRequest ideas or functions that would be useful

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants