orchestrator: Wire CommitSvnFloor through the platform driver - #437
Open
chrysh wants to merge 1 commit into
Open
orchestrator: Wire CommitSvnFloor through the platform driver#437chrysh wants to merge 1 commit into
chrysh wants to merge 1 commit into
Conversation
chrysh
force-pushed
the
wire-svn-commit
branch
5 times, most recently
from
August 26, 2026 18:58
13069cf to
ac56e28
Compare
chrysh
marked this pull request as ready for review
August 26, 2026 19:04
leongross
reviewed
Aug 27, 2026
| type Verifier: Verifier; | ||
| /// Reset actuation for the managed components. | ||
| type BootControl: BootControl; | ||
| /// The durable anti-rollback floor of the managed components. |
Member
There was a problem hiding this comment.
why is this durable? what does this imply?
Contributor
Author
There was a problem hiding this comment.
Durable means it survives power loss and reboot. Fixed in doc comment.
| /// `verified_svn[i]` is the manifest SVN of `ComponentId(i)`'s last | ||
| /// authenticated image — the only value a floor commit may trust. | ||
| /// `None` until a verification passes; cleared again on rejection. | ||
| verified_svn: [Option<Svn>; N], |
Member
There was a problem hiding this comment.
Please correct me if I'm wrong, but both the board capabilites as well as the verified_svn track SVNs for the downstream devices, right? So Why does a None in board capabilities resemble a self-managed device, and a None here must imply "empty until verification passes"? This is misleading and kind of breaks the API for me. We should find clearer ways to indicate what we want to say to prohibit future misuse.
Contributor
Author
There was a problem hiding this comment.
Good catch, that's indeed confusing. Fixed.
chrysh
force-pushed
the
wire-svn-commit
branch
from
August 27, 2026 19:09
ac56e28 to
fa0aa8c
Compare
SvnFloor joins BoardCapabilities, one floor per component slot. The SVN to advance to travels in Verdict::Authenticated: verification is the only authenticated read of the manifest, so nothing else may tell the floor where to go. The driver caches it per component, clears it on rejection, and fails closed when asked to commit without it. SvnFloorBinding names the two wirings a board can choose: Erot, where the eRoT holds the floor, and SelfManaged for a component that tracks its own SVN (iRoT, or a PLDM device committing internally), whose commit is a no-op. Assisted-by: Claude:claude-fable-5 Signed-off-by: Christina Quast <christina.quast@9elements.com>
chrysh
force-pushed
the
wire-svn-commit
branch
from
August 27, 2026 19:28
fa0aa8c to
bc6dd04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR can only be merged after we get an answer on Slack about SVN conventions between iRoT and eRoT.
SvnFloor joins BoardCapabilities, one floor per component slot. The SVN to advance to travels in
Verdict::Authenticated: verification is the only authenticated read of the manifest, so nothing else may tell the floor where to go. The driver caches it per component, clears it on rejection, and fails closed when asked to commit without it. ANoneslot marks a component that tracks its own SVN (iRoT, or a PLDM device committing internally); the eRoT keeps no second floor for it and its commit is a no-op.Part of 9elements#18