orchestrator: Compose report delivery from the board's ReportSink capability - #448
Draft
chrysh wants to merge 2 commits into
Draft
orchestrator: Compose report delivery from the board's ReportSink capability#448chrysh wants to merge 2 commits into
chrysh wants to merge 2 commits into
Conversation
The four Effect::Report* variants have no consumer seam. Add a non_exhaustive Report enum and a single ReportSink::report instead of a method or a trait per variant, so a new report is one variant rather than a trait break and a sink routes only what it recognises. report returns nothing: a report names something that already happened, so an undeliverable one costs information, not containment, and reporting stays off the driver's fail-closed path. A sink that needs to know it dropped one records that on its own side. Every payload stays Copy and lifetime-free, like the effects these mirror; a report names its component and nothing more. The unit impl drops them, for a board with no management side to tell. Trait only, composing a sink into the board follows. Assisted-by: Claude:claude-opus-5
…ability BoardCapabilities gains ReportSink and Board a single report_sink field, one per platform rather than one per component: two of the four reports name no component. The Report effects leave the not-yet-composed group and hand their Report to the sink. Executing a report returns no error, so it never reaches the fail-closed group: an Isolable component is contained, reported, and the platform stays Ready. Delivery order is the SM's emission order. WatchBoard wires the unit sink, so the no-op impl is exercised through a real board rather than a test written for it. Assisted-by: Claude:claude-opus-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #447 — review the last commit only.
BoardCapabilitiesgains aReportSinkandBoarda singlereport_sinkfield, one per platform rather than one per component: two of the four reports name no component. TheReporteffects leave the not-yet-composed group and hand theirReportto the sink.Executing a report returns no error, so it never reaches the fail-closed group: an
Isolablecomponent is contained, reported, and the platform staysReady.WatchBoardwires(), so the no-op impl is exercised through a real board rather than a test written for it.Not settled here: what should happen when a report cannot be delivered. The seam keeps the SM safe either way, but a dropped
ReportIsolatedis currently unrecoverable, since isolation state is not queryable outside the report itself. To discuss before this leaves draft.References 9elements#3.