Make opensips behave consistently in respect of nsswitch regardless of DNS caching.#2434
Open
bambyster wants to merge 1 commit into
Open
Make opensips behave consistently in respect of nsswitch regardless of DNS caching.#2434bambyster wants to merge 1 commit into
bambyster wants to merge 1 commit into
Conversation
|
Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days. |
|
Marking as closed due to lack of progress for more than 30 days. If this issue is still relevant, please re-open it with additional details. |
|
Any updates here? No progress has been made in the last 15 days, marking as stale. Will close this issue if no further updates are made in the next 30 days. |
Contributor
|
The problem with this patch is that we don't have any TTL information when using gethostbyXXX() functions. :( As such it breaks invalidation of the cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current integration with dns_cache module has an issue. When dns_cache module is disabled the OpenSIPS uses gethostbyname(), gethostbyname2(), gethostbyaddr() functions from libc which respect the nsswitch.conf settings and for example automatically perform a lookup in /etc/hosts. However when dns_cache is enabled the OpenSIPS starts to use res_search() instead, which only performs DNS lookups and as a result it becomes impossible to query other name resolution services configured in the nsswitch.conf.
I propose to use gethostby*() functions consistently regardless of caching settings.