Skip to content

Commit b5b2505

Browse files
Roland Lichtersjenkins
authored andcommitted
QPR-12455 update portfolio and notebook
1 parent 4345e87 commit b5b2505

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

Examples/Example_62/Input/portfolio.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@
355355
</TaRFData>
356356
</Trade>
357357

358-
<Trade id="6:TaRF">
358+
<Trade id="6:TaRF_2">
359359
<TradeType>ScriptedTrade</TradeType>
360360
<Envelope>
361361
<CounterParty>CPTY</CounterParty>

Examples/Example_62/ore.ipynb

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,8 @@
168168
"outputs": [],
169169
"source": [
170170
"# Compare Sensitivities\n",
171+
"# If we set pricing engine's ExternalDeviceCompatibilityMode to false, then get zero deviations from the reference run above\n",
172+
"# if we set ExternalDeviceCompatibilityMode to true, then we see differences below due to different ordering of random variates in both runs\n",
171173
"utilities.match_sensi_reports(ore, ore_cg, \"DeltaBump\", \"DeltaCG\", False)"
172174
]
173175
},
@@ -320,7 +322,7 @@
320322
"outputs": [],
321323
"source": [
322324
"# Compare Pricing Stats\n",
323-
"utilities.match_pricingstats_123(ore, ore_ad, ore_gpu, \"SpeedupAD\", \"SpeedupGPU\", False)"
325+
"utilities.match_pricingstats_123(ore_cg, ore_ad, ore_gpu, \"SpeedupAD\", \"SpeedupGPU\", False)"
324326
]
325327
},
326328
{
@@ -330,17 +332,17 @@
330332
"outputs": [],
331333
"source": [
332334
"# Compare Sensitivities\n",
333-
"utilities.match_sensi_reports(ore, ore_gpu, \"DeltaBump\", \"DeltaGPU\", False)"
335+
"# to the reference run with both UseCG and ExternalDeviceCompatibilityMode set to true\n",
336+
"utilities.match_sensi_reports(ore_cg, ore_gpu, \"DeltaBump\", \"DeltaGPU\", False)"
334337
]
335338
},
336339
{
337340
"cell_type": "markdown",
338341
"metadata": {},
339342
"source": [
340343
"### Todos\n",
341-
"- debug the BasicCpu device calculation\n",
342-
"- double precision for the OpenCL implementation\n",
343-
"- random number generators for the OpenCL implementation (MT antithetic, Sobol, Sobol BB)\n",
344+
"- check the OpenCL implementation with devices that support double precision, e.g. Nvidia\n",
345+
"- add random number generators to the OpenCL implementation (MT antithetic, Sobol, Sobol BB)\n",
344346
"- CUDA implementation"
345347
]
346348
},

0 commit comments

Comments
 (0)