Skip to content

Add simple PR tests #77

Open
Open

Description

@gonX

Some ideas:

JSON Key Check
Name ^.{2,}$ (2 characters or more)
Description same as Name
Owner ^[^\s]+$
SupportedDriverVersion Must be lower than newest release, and have all 4 version subvalues (e.g. 0.6.4.0, not 0.6.4)
PluginVersion ^\d+(\.\d+){1,2}$ or less strict
*Url must be curl'able (or similar)
CompressionFormat Whatever we support, zip only for now? Can skip this check
LicenseIdentifier Ideally, something from a predermined list, but otherwise same check as Owner

Already covered in tests:

  • SHA256
  • DownloadUrl

Activity

  1. gonX commented on Nov 30, 2023

    @gonX
    MemberAuthor

    Oops, we already have some tests:
    https://github.com/OpenTabletDriver/Plugin-Repository/blob/acc79dccf8325459e2e3f6b2be8bd4c197c222ed/validate.sh

    Looks like SHA256 (and DownloadUrl) are the only ones getting tested there, as well as checking whether the file is parseable at all.

  2. gonX commented on Mar 18, 2024

    @gonX
    MemberAuthor

    Updated OP to address issues fixed in #89

  3. gonX commented on Mar 18, 2024

    @gonX
    MemberAuthor

    Also need to test for path as seen in #90 and #126. Fixed in #127

  4. Kuuuube commented on May 25, 2025

    @Kuuuube
    Member

    Path test added in #127

  5. changed the title [-]Add PR tests[/-] [+]Add simple PR tests[/+] on Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions