Skip to content

feat(trigger): add save db option#139

Merged
Yan-Muzi merged 1 commit into
mainfrom
perf-db
Jul 6, 2026
Merged

feat(trigger): add save db option#139
Yan-Muzi merged 1 commit into
mainfrom
perf-db

Conversation

@Yan-Muzi

@Yan-Muzi Yan-Muzi commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an opt-in “dump simulator DB” workflow to the perf trigger so emulator runs can persist a simulator.db artifact per checkpoint result directory, and the reset logic cleans it up when needed.

Changes:

  • Add dump_db: bool to EmuConfig and plumb it from CLI (--dump-db) into run configuration.
  • Extend remote emu invocation to pass --dump-db --db-path <result>/simulator.db when enabled.
  • Add GCPT.db_path and delete simulator.db during reset_running_gcpt() (when present).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
perf_trigger/modules/types.py Adds dump_db flag to the run configuration model.
perf_trigger/modules/server.py Conditionally forwards DB dump flags/paths to the remote emu command.
perf_trigger/modules/gcpt.py Introduces db_path helper for consistent DB file location.
perf_trigger/main.py Adds --dump-db CLI switch and cleans up the DB file on reset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Yan-Muzi
Yan-Muzi merged commit 73bdfc7 into main Jul 6, 2026
1 check passed
@Yan-Muzi
Yan-Muzi deleted the perf-db branch July 6, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants