fix: a backup restores text that looks like a number as text - #945
Merged
Merged
Conversation
blaipr
deleted the
fix/a-backup-restores-text-that-looks-like-a-number
branch
September 24, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The database backup dump (
BackupFile) wrote every valueis_numeric()accepted as a bare SQL literal.is_numeric()is true of text that only looks numeric, and a bare literal is a number to MySQL. So restoring a backup silently changed text columns:So an account login of
0123, an account or client named0800, or a note reading1e5would come back as123,800and100000. The backup is the recovery path, so this only shows up on the day it's needed.Change
The decision is now made by the column's type, not by what the value looks like:
intand every text column asstring. This was measured against MariaDB with both native and emulated prepares.Tests
FileBackupServiceTest::testTextThatLooksLikeANumberIsDumpedAsTextchecks that a row of'0123', 5, '1e5', ' 7', 2.5, NULLis dumped asVALUES('0123',5,'1e5',' 7',2.5,NULL). It fails without the fix.