fix: a master password is held to its minimum at every door - #946
Merged
blaipr merged 1 commit intoSep 24, 2026
Merged
Conversation
blaipr
deleted the
fix/a-master-password-is-held-to-its-minimum-at-every-door
branch
September 24, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every account secret is sealed with the master password, so its minimum length is the floor under the whole vault. Only the installer enforced it, and it measured in bytes:
Installerrefused under 11, but counted withstrlen(), so five CJK characters (15 bytes) passed a rule that says "at least 11 characters".sp:updateMasterPasswordaccepted any non-empty value too.So an installation could be re-keyed to
athe day after it was set up.Change
MasterPass::MIN_LENGTH(11) andMasterPass::assertLongEnough(), measured withmb_strlen(). It is asked by:MasterPass::changeMasterPassword(), which the web rotation and the CLI both reach, before anything is re-encryptedconfigEncryption/saveaction, after the same/repeat checks, because its "hash only" option replaces the stored hash without going through the rotationTests
MasterPassTestcases used456andnewas new master passwords; they now use realistic ones.All four new tests fail without the fix.