Skip to content

Don't fail petablint for PEtab v2 problems with only warnings - #569

Draft
dweindl wants to merge 1 commit into
PEtab-dev:mainfrom
dweindl:petablint_v2_warnings
Draft

dweindl wants to merge 1 commit into
PEtab-dev:mainfrom
dweindl:petablint_v2_warnings

Conversation

@dweindl

@dweindl dweindl commented Oct 21, 2026

Copy link
Copy Markdown
Member

For PEtab v2 problems, petablint exited with 1 for any validation issue, including warnings such as unused conditions. Now it reports all issues but only fails if there are errors, consistent with PEtab v1.

Closes #567.

🤖 Generated with Claude Code

@dweindl dweindl self-assigned this Oct 21, 2026
For PEtab v2 problems, `petablint` exited with 1 for any validation
issue, including warnings. Now it reports all issues but only fails if
there are errors, consistent with PEtab v1.

Closes PEtab-dev#567.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.85%. Comparing base (68be6d1) to head (cacd2c1).

Files with missing lines Patch % Lines
petab/petablint.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files          69       69           
  Lines        8043     8043           
  Branches     1445     1445           
=======================================
  Hits         6342     6342           
  Misses       1214     1214           
  Partials      487      487           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

petablint fails for PEtab v2 problems with only warnings

2 participants